* [PATCH 00/10] ARM64: dts: Fix incomplete cooling-maps
@ 2018-11-16 10:04 Viresh Kumar
2018-11-16 10:04 ` [PATCH 09/10] ARM64: dts: rockchip: Add all CPUs in cooling maps Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2018-11-16 10:04 UTC (permalink / raw)
To: Mark Rutland, Rob Herring, arm, Andy Gross, Carlo Caione,
David Brown, Heiko Stuebner, Kevin Hilman, Krzysztof Kozlowski,
Kukjin Kim, Li Yang, Magnus Damm, Masahiro Yamada,
Matthias Brugger, Shawn Guo, Simon Horman, Wei Xu
Cc: Viresh Kumar, devicetree, Vincent Guittot, Daniel Lezcano,
linux-arm-kernel, linux-amlogic, linux-arm-msm, linux-kernel,
linux-mediatek, linux-renesas-soc, linux-rockchip,
linux-samsung-soc, linux-soc
Hello,
Now that the below commit are merged in mainline, we can start fixing
the ARM64 platform specific DT files:
commit d7a4303b8d1f ("dt-bindings: thermal: Allow multiple devices to
share cooling map")
commit a92bab8919e3 ("of: thermal: Allow multiple devices to share
cooling map")
Each CPU can (and does) participate in cooling down the system but the
DT only captures a handful of them, normally CPU0, in the cooling maps.
Things work by chance currently as under normal circumstances its the
first CPU of each cluster which is used by the operating systems to
probe the cooling devices. But as soon as this CPU ordering changes and
any other CPU is used to bring up the cooling device, we will start
seeing failures.
Also the DT is rather incomplete when we list only one CPU in the
cooling maps, as the hardware doesn't have any such limitations.
Update cooling maps to include all devices affected by individual trip
points.
Individual maintainers can take the patches through their tree.
--
viresh
Viresh Kumar (10):
ARM64: dts: amlogic: Add all CPUs in cooling maps
ARM64: dts: exynos: Add all CPUs in cooling maps
ARM64: dts: fsl: Add all CPUs in cooling maps
arm64: dts: hi3660: Add missing cooling device properties for CPUs
ARM64: dts: hisilicon: Add all CPUs in cooling maps
ARM64: dts: mediatek: Add all CPUs in cooling maps
ARM64: dts: msm8916: Add all CPUs in cooling maps
ARM64: dts: renesas: Add all CPUs in cooling maps
ARM64: dts: rockchip: Add all CPUs in cooling maps
ARM64: dts: uniphier: Add all CPUs in cooling maps
.../dts/amlogic/meson-gxm-khadas-vim2.dts | 22 +++++-------
.../arm64/boot/dts/exynos/exynos5433-tmu.dtsi | 36 ++++++++++++-------
.../arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 6 ++--
.../arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 6 ++--
.../arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 17 +++++----
.../arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 28 +++++----------
arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 16 +++++++--
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 9 ++++-
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 9 +++--
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 6 ++--
arch/arm64/boot/dts/qcom/msm8916.dtsi | 10 ++++--
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 15 ++++++--
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 6 ++--
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 5 ++-
arch/arm64/boot/dts/rockchip/rk3368.dtsi | 15 ++++++--
.../boot/dts/rockchip/rk3399-gru-kevin.dts | 8 +++--
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 +++++--
.../boot/dts/socionext/uniphier-ld20.dtsi | 11 +++---
18 files changed, 147 insertions(+), 90 deletions(-)
--
2.19.1.568.g152ad8e3369a
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 09/10] ARM64: dts: rockchip: Add all CPUs in cooling maps
2018-11-16 10:04 [PATCH 00/10] ARM64: dts: Fix incomplete cooling-maps Viresh Kumar
@ 2018-11-16 10:04 ` Viresh Kumar
2018-11-26 13:16 ` Heiko Stuebner
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2018-11-16 10:04 UTC (permalink / raw)
To: Mark Rutland, Rob Herring, arm, Heiko Stuebner
Cc: Viresh Kumar, devicetree, Vincent Guittot, Daniel Lezcano,
linux-arm-kernel, linux-rockchip, linux-kernel
Each CPU can (and does) participate in cooling down the system but the
DT only captures a handful of them, normally CPU0, in the cooling maps.
Things work by chance currently as under normal circumstances its the
first CPU of each cluster which is used by the operating systems to
probe the cooling devices. But as soon as this CPU ordering changes and
any other CPU is used to bring up the cooling device, we will start
seeing failures.
Also the DT is rather incomplete when we list only one CPU in the
cooling maps, as the hardware doesn't have any such limitations.
Update cooling maps to include all devices affected by individual trip
points.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 5 ++++-
arch/arm64/boot/dts/rockchip/rk3368.dtsi | 15 ++++++++++++---
arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 8 ++++++--
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 +++++++++---
4 files changed, 31 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index e1a33dd981e0..ecd7f19c3542 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -479,7 +479,10 @@
cooling-maps {
map0 {
trip = <&target>;
- cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
contribution = <4096>;
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
index 9c24de1ba43c..7014d10b954c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
@@ -426,12 +426,18 @@
map0 {
trip = <&cpu_alert0>;
cooling-device =
- <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_b1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_b2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_b3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
};
map1 {
trip = <&cpu_alert1>;
cooling-device =
- <&cpu_l0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ <&cpu_l0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_l1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_l2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_l3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
};
};
};
@@ -459,7 +465,10 @@
map0 {
trip = <&gpu_alert0>;
cooling-device =
- <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_b1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_b2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_b3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
};
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
index 2cc7c47d6a85..81e73103fa78 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts
@@ -118,13 +118,17 @@
map0 {
trip = <&ppvar_bigcpu_alert>;
cooling-device =
- <&cpu_l0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ <&cpu_l0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_l1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_l2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_l3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
contribution = <4096>;
};
map1 {
trip = <&ppvar_bigcpu_alert>;
cooling-device =
- <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_b1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
contribution = <1024>;
};
};
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 99e7f65c1779..d4ebffc28953 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -770,13 +770,18 @@
map0 {
trip = <&cpu_alert0>;
cooling-device =
- <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_b1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
};
map1 {
trip = <&cpu_alert1>;
cooling-device =
<&cpu_l0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
- <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ <&cpu_l1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_l2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_l3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_b1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
};
};
};
@@ -804,7 +809,8 @@
map0 {
trip = <&gpu_alert0>;
cooling-device =
- <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+ <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+ <&cpu_b1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
};
};
};
--
2.19.1.568.g152ad8e3369a
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 09/10] ARM64: dts: rockchip: Add all CPUs in cooling maps
2018-11-16 10:04 ` [PATCH 09/10] ARM64: dts: rockchip: Add all CPUs in cooling maps Viresh Kumar
@ 2018-11-26 13:16 ` Heiko Stuebner
0 siblings, 0 replies; 3+ messages in thread
From: Heiko Stuebner @ 2018-11-26 13:16 UTC (permalink / raw)
To: Viresh Kumar
Cc: Mark Rutland, Rob Herring, arm, devicetree, Vincent Guittot,
Daniel Lezcano, linux-arm-kernel, linux-rockchip, linux-kernel
Am Freitag, 16. November 2018, 11:04:32 CET schrieb Viresh Kumar:
> Each CPU can (and does) participate in cooling down the system but the
> DT only captures a handful of them, normally CPU0, in the cooling maps.
> Things work by chance currently as under normal circumstances its the
> first CPU of each cluster which is used by the operating systems to
> probe the cooling devices. But as soon as this CPU ordering changes and
> any other CPU is used to bring up the cooling device, we will start
> seeing failures.
>
> Also the DT is rather incomplete when we list only one CPU in the
> cooling maps, as the hardware doesn't have any such limitations.
>
> Update cooling maps to include all devices affected by individual trip
> points.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
looks like I forgot to respond ... applied like 7 days ago
and already part of my pull-request for 4.21
Thanks
Heiko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-26 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-16 10:04 [PATCH 00/10] ARM64: dts: Fix incomplete cooling-maps Viresh Kumar
2018-11-16 10:04 ` [PATCH 09/10] ARM64: dts: rockchip: Add all CPUs in cooling maps Viresh Kumar
2018-11-26 13:16 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).