From: Ezequiel Garcia <ezequiel@collabora.com>
To: Johan Jonker <jbx6244@gmail.com>,
netdev@vger.kernel.org, linux-rockchip@lists.infradead.org
Cc: Jose Abreu <joabreu@synopsys.com>,
Heiko Stuebner <heiko@sntech.de>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Peter Geis <pgwipeout@gmail.com>,
Kever Yang <kever.yang@rock-chips.com>,
David Wu <david.wu@rock-chips.com>,
kernel@collabora.com
Subject: Re: [PATCH v2 3/3] net: stmmac: Add RK3566 SoC support
Date: Wed, 21 Apr 2021 18:06:13 -0300 [thread overview]
Message-ID: <d1de806e3989900a8a6477f35dce1575473a8983.camel@collabora.com> (raw)
In-Reply-To: <a3cef507-6480-eff8-625c-c5167db718f3@gmail.com>
On Wed, 2021-04-21 at 22:49 +0200, Johan Jonker wrote:
> On 4/21/21 10:34 PM, Ezequiel Garcia wrote:
> > From: David Wu <david.wu@rock-chips.com>
> >
> > Add constants and callback functions for the dwmac present
> > on RK3566 SoCs. As can be seen, the base structure
> > is the same, only registers and the bits in them moved slightly.
> >
> > The dwmac IP core version v5.1, and so the compatible string
> > is expected to be:
> >
> > compatible = "rockchip,rk3566-gmac", "snps,dwmac-4.20a";
> >
> > Signed-off-by: David Wu <david.wu@rock-chips.com>
> > [Ezequiel: Separate rk3566-gmac support]
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > ---
> > .../bindings/net/rockchip-dwmac.txt | 1 +
> > .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 89 +++++++++++++++++++
> > 2 files changed, 90 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.txt b/Documentation/devicetree/bindings/net/rockchip-dwmac.txt
> > index 3b71da7e8742..3bd4bbcd6c65 100644
> > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.txt
> > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.txt
> > @@ -12,6 +12,7 @@ Required properties:
> > "rockchip,rk3366-gmac": found on RK3366 SoCs
> > "rockchip,rk3368-gmac": found on RK3368 SoCs
> > "rockchip,rk3399-gmac": found on RK3399 SoCs
>
> > + "rockchip,rk3566-gmac", "snps,dwmac-4.20a": found on RK3566 SoCs
>
> This is still a text document.
> rob+dt has now scripts that check for undocumented compatibility
> strings, so first convert rockchip-dwmac.txt to YAML and then add this
> in a separated patch.
>
Is it a showstopper to convert devicetree bindings to YAML, for driver submission?
Thanks,
Ezequiel
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-04-21 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 20:34 [PATCH v2 net-next 0/3] net: stmmac: RK3566 Ezequiel Garcia
2021-04-21 20:34 ` [PATCH v2 1/3] net: stmmac: Don't set has_gmac if has_gmac4 is set Ezequiel Garcia
2021-04-21 20:34 ` [PATCH v2 2/3] net: stmmac: dwmac-rk: Check platform-specific ops Ezequiel Garcia
2021-04-21 20:34 ` [PATCH v2 3/3] net: stmmac: Add RK3566 SoC support Ezequiel Garcia
2021-04-21 20:49 ` Johan Jonker
2021-04-21 21:06 ` Ezequiel Garcia [this message]
2021-04-23 9:24 ` [PATCH v2 net-next 0/3] net: stmmac: RK3566 David Wu
2021-04-23 13:57 ` Ezequiel Garcia
2021-04-25 9:07 ` David Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1de806e3989900a8a6477f35dce1575473a8983.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kernel@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=kuba@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pgwipeout@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox