From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D47E2E77184 for ; Fri, 20 Dec 2024 02:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zQPk/t2w5Mu/3N2LjjNoHkQ9W2f7+FgzN5w0tjTIgro=; b=hN1diVq2BIFt982X7JOF8PZ/Tx /ZfM6i2xk4DfT6LCoHoqVRit98ntKcN4F0KclF0tH3IwnQvL0LGtCk3hif72HutRRd1egEm58f12Q 8Y9zqF9W9eXgAI1m0s3J8MEOXgZH8Zt+4Iq3rc4GhUvk7OHKxQcsrS+v49TPZo+meSwI7TaNJXuvz oy+3IUPsls+PSj8Crma6Uycju+xa/nNgPUVJoD/ze+xFjgRidFa99pSFrClYvR5/09Ji7vWkSh+IO CQErGj8IBjElXrDPw9CO/gJLdMRq6uPhoDSO181/y7JwRNeGp52RQOcedJJVd1M7gW7COTymXWaW+ 19NR63SA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tOSun-00000003jK6-0CLk; Fri, 20 Dec 2024 02:38:57 +0000 Received: from mail-m49217.qiye.163.com ([45.254.49.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tOSuj-00000003jIz-1CwU; Fri, 20 Dec 2024 02:38:55 +0000 Received: from [172.16.12.26] (unknown [58.22.7.114]) by smtp.qiye.163.com (Hmail) with ESMTP id 6471a82d; Fri, 20 Dec 2024 10:38:48 +0800 (GMT+08:00) Message-ID: Date: Fri, 20 Dec 2024 10:38:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/15] arm64: dts: rockchip: Enable eDP0 display on RK3588S EVB1 board To: Dmitry Baryshkov References: <20241219080604.1423600-1-damon.ding@rock-chips.com> <20241219080604.1423600-15-damon.ding@rock-chips.com> Content-Language: en-US From: Damon Ding In-Reply-To: X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQhhLTFZOHx0eGkJPTUhOQ09WFRQJFh oXVRMBExYaEhckFA4PWVdZGBILWUFZTkNVSUlVTFVKSk9ZV1kWGg8SFR0UWUFZT0tIVUpLSUhCSE NVSktLVUpCS0tZBg++ X-HM-Tid: 0a93e1ee8f8203a3kunm6471a82d X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NT46PAw6HDIVUQpMFjw5HS8u LUswCy1VSlVKTEhPTU1JSElCQ0NDVTMWGhIXVR8aFhQVVR8SFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFIS0hNNwY+ DKIM-Signature: a=rsa-sha256; b=A8qVBaED3moEexWbmxTX0uIE4JtNKgnCz0rvl14Oua2kyttsbBvYnqqNWb/jOpim28o1B1/geTDzwzzWYp5b4YeXqaC1HFRvy4ER8UU4sEgU17gRAlFtAww+S64mHq4cQn1DqNRp1TESg+RXS51+aX7s3QNTJwg/1PlYlAC/6WA=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=J9jrXyKQlgCN3Z+wY6wP74KB04Bf5lEp5T52IcpdDIw=; h=date:mime-version:subject:message-id:from; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241219_183853_888011_CDA701FB X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, conor+dt@kernel.org, algea.cao@rock-chips.com, rfoss@kernel.org, heiko@sntech.de, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, sebastian.reichel@collabora.com, dri-devel@lists.freedesktop.org, hjc@rock-chips.com, kever.yang@rock-chips.com, linux-rockchip@lists.infradead.org, vkoul@kernel.org, andy.yan@rock-chips.com, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Dmitry, On 2024/12/20 8:20, Dmitry Baryshkov wrote: > On Thu, Dec 19, 2024 at 04:06:03PM +0800, Damon Ding wrote: >> Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board: >> - Add edp-panel node >> - Set pinctrl of pwm12 for backlight >> - Enable edp0/hdptxphy0/vp2 >> >> Signed-off-by: Damon Ding >> >> --- >> >> Changes in v2: >> - Remove brightness-levels and default-brightness-level properties in >> backlight node. >> - Add the detail DT changes to commit message. >> >> Changes in v3: >> - Use aux-bus instead of platform bus for edp-panel. >> --- >> .../boot/dts/rockchip/rk3588s-evb1-v10.dts | 52 +++++++++++++++++++ >> 1 file changed, 52 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >> index bc4077575beb..9547ab18e596 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >> @@ -9,6 +9,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include "rk3588s.dtsi" >> >> @@ -238,6 +239,41 @@ &combphy2_psu { >> status = "okay"; >> }; >> >> +&edp0 { >> + force-hpd; >> + status = "okay"; >> + >> + aux-bus { >> + panel { >> + compatible = "lg,lp079qx1-sp0v"; > > Why do you need the particular compat string here? Can you use the > generic "edp-panel" instead? What if the user swaps the panel? > The eDP panels used in conjunction with the RK3588S EVB1 have broken identification, which is one of the valid reasons for using a particular compat string. So the generic_edp_panel_probe() can not return success when using the "edp-panel". >> + backlight = <&backlight>; >> + power-supply = <&vcc3v3_lcd_edp>; >> + >> + port { >> + panel_in_edp: endpoint { >> + remote-endpoint = <&edp_out_panel>; >> + }; >> + }; >> + }; >> + }; >> +}; >> + >> +&edp0_in { >> + edp0_in_vp2: endpoint { >> + remote-endpoint = <&vp2_out_edp0>; >> + }; >> +}; >> + >> +&edp0_out { >> + edp_out_panel: endpoint { >> + remote-endpoint = <&panel_in_edp>; >> + }; >> +}; >> + >> +&hdptxphy0 { >> + status = "okay"; >> +}; >> + >> &i2c3 { >> status = "okay"; >> >> @@ -399,6 +435,7 @@ usbc0_int: usbc0-int { >> }; >> >> &pwm12 { >> + pinctrl-0 = <&pwm12m1_pins>; >> status = "okay"; >> }; >> >> @@ -1168,3 +1205,18 @@ usbdp_phy0_dp_altmode_mux: endpoint@1 { >> }; >> }; >> }; >> + >> +&vop_mmu { >> + status = "okay"; >> +}; >> + >> +&vop { >> + status = "okay"; >> +}; >> + >> +&vp2 { >> + vp2_out_edp0: endpoint@ROCKCHIP_VOP2_EP_EDP0 { >> + reg = ; >> + remote-endpoint = <&edp0_in_vp2>; >> + }; >> +}; >> -- >> 2.34.1 >> > Best regards, Damon _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip