From: Dragan Simic <dsimic@manjaro.org>
To: Andrey Leonchikov <andreil499@gmail.com>
Cc: linux-rockchip@lists.infradead.org
Subject: Re: [v2,PATCH 5/5] RK356x - Add OTP description.
Date: Fri, 12 Sep 2025 12:45:33 +0200 [thread overview]
Message-ID: <d2c86c0da199eaeb49cf3463e3eb9a77@manjaro.org> (raw)
In-Reply-To: <20250910215451.2244192-6-andreil499@gmail.com>
Hello Andrey,
Thanks for your patch series. Please note that this patch (i.e. 5/5)
doesn't belong to the series, because it addresses a completely separate
topic, so please resend it as a separate patch and Cc me; I'll then be
happy to review this patch in detail.
On 2025-09-10 23:54, Andrey Leonchikov wrote:
> OTP mapping, based on RK3568 datasheet and BIQU DTS.
Please note that an empty line is required between the patch description
and the tag(s), which applies to all patches in your series.
> Signed-off-by: Andrey Leonchikov <andreil499@gmail.com>
Next, patch summaries/subjects require a proper prefix, which in this
case
is "arm64: dts: rockchip:". You can always have a look at the Git log
for
the file you're changing, to determine what's the right prefix to use.
You're also missing some of the required recipients in the To and Cc
lists.
Please, have a look at Documentation/process/submitting-patches.rst and
scripts/get_maintainer.pl in the kernel source for more details.
Finally, both the patch summaries and the patch descriptions in your
series
require a bit of rewording, to conform to the usual language and to
provide
more details. Having a look at the Git log also helps there.
Oh, and where's the v1 of this series? Am I missing something?
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-09-12 10:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-10 21:54 [v2,PATCH 0/5] RK3566 BigtreeTech Pi2 fixes Andrey Leonchikov
2025-09-10 21:54 ` [v2,PATCH 1/5] RK3566 BTT Pi2 DTS fixes Andrey Leonchikov
2025-09-10 21:54 ` [v2,PATCH 2/5] RK3566 BTT Pi2 - Fix GMAC default delays Andrey Leonchikov
2025-09-12 15:06 ` Jonas Karlman
2025-09-10 21:54 ` [v2,PATCH 3/5] RK3566 BTT Pi2 - Fix RK808 clock names. Require for a normal shutdown/reboot Andrey Leonchikov
2025-09-10 21:54 ` [v2,PATCH 4/5] RK3566 BTT Pi2 - Fix default values Andrey Leonchikov
2025-09-10 21:54 ` [v2,PATCH 5/5] RK356x - Add OTP description Andrey Leonchikov
2025-09-12 10:45 ` Dragan Simic [this message]
2025-09-12 12:49 ` Andrey Leonchikov
2025-09-13 14:58 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2c86c0da199eaeb49cf3463e3eb9a77@manjaro.org \
--to=dsimic@manjaro.org \
--cc=andreil499@gmail.com \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox