From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7083C83F1D for ; Sat, 12 Jul 2025 15:30:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZFl05Wi1Xwz03b6cdmmGl1v/jFswA0DDXY3rdumPFlc=; b=we/GExya6Qv0OS tprO6P2ukhrUoIRYxNXPS/rncT1eemOibf46xL25z9yvhYdOQ5nVeBZgAQDh75T571yKd3+/JKBkM S19wmoHb/WcKaP5tjRm5amlub8Psec4tW4XyUmfU0WrVkeZ+3W2v1E9CGXNoaPU/nt8Mj2+PocfE8 FvSFPsPKEXqO3H9lequFOpT5z+Vr+puG3JveL6Q38NXZGICfmL+eBPnc7QSxSVN2+YLFUJFznVqG+ f+RwcKb76tqGI/IJ04RBe78ccGU0C6vUDHEOMukK0AA7shZBfoDXYc2F1G6e7IOPnyHTJfBDVkXSI OE2/81FBv4WVYAm7XxuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uacBa-0000000GlY4-3Mmy; Sat, 12 Jul 2025 15:30:46 +0000 Received: from smtp.forwardemail.net ([121.127.44.73]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uac9A-0000000GlSh-3tEa for linux-rockchip@lists.infradead.org; Sat, 12 Jul 2025 15:28:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1752334093; bh=lZx2NZXuKQJ5MZ9Menod0GULsbjcKgAMbN3yCF9Zij0=; b=uQ8haAeCDZvZPeMmV/lOzU4dUUFRUPwhGYxhVn0NeCPSU5s00bgrBV1N0r6wbYK6FmQkXEYoI 4J7SD9WMkw6FIwaQckg59iMYdiCJBeBwxpet/8C6PCLRv46l+91rYWVxKyKpZzxQdOxEgIAEEeO Xzepq7v4X1ykFgY8BExwV22VdKrbNJWdNRn+/+qflCc98OCy64fJEl6W3+ROcHzySwJ0jMa/lnm 1i0PSmcCtCx7mFlSLcBOgluhFpuAT2eKZC7h/qdqeDgorK1B2tktCLPk9tphuTjFlMAJOUqPPXR i4C8NORCZEgFBl2SCd/8ttmS1IhyhEwnAoID6kyPJbUA== X-Forward-Email-ID: 68727c4bd7dd91652d167c59 X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 121.127.44.73 X-Forward-Email-Version: 1.1.6 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Message-ID: Date: Sat, 12 Jul 2025 17:16:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/6] arm64: dts: rockchip: Add ArmSoM Sige1 To: Chukun Pan Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, heiko@sntech.de, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, ziyao@disroot.org References: <20250712040019.165440-1-amadeus@jmu.edu.cn> Content-Language: en-US From: Jonas Karlman In-Reply-To: <20250712040019.165440-1-amadeus@jmu.edu.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250712_082817_091340_673E02BB X-CRM114-Status: GOOD ( 14.57 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi, On 7/12/2025 6:00 AM, Chukun Pan wrote: > Hi, > >>> Should this label be named as led-0/led-1? > >> The nodes must include 'led' anywhere in their name according to schema: >> >> """ >> patternProperties: >> # The first form is preferred, but fall back to just 'led' anywhere in the >> # node name to at least catch some child nodes. >> "(^led-[0-9a-f]$|led)": >> """ >> >> Using the color name similar to the the pin labels in schematics made >> most sense to me. >> >> Do you want me to change these to conform to the more restricted >> ^led-[0-9a-f]$ pattern? > > This will be better. Will change the node names of the leds in a v3. > >> I only try to enable controllers for devices that are properly described, >> so I ignored the pwm-fan and its required pwm6 controller. Mostly >> because it make more sense to describe the fan once thermal support is >> completed, work [1] currently being blocked by a rk356x otp series [2] >> and that depends on a rk3576 thermal series [3]. > > Ok, I got it. Is usb2.0 also stuck? USB2.0 is mostly stuck due to my limited time and possible power-domain, will try to send the USB2.0 patches to mailing list tomorrow. Regards, Jonas > > Thanks, > Chukun > > -- > 2.25.1 > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip