From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0D1EC761AF for ; Tue, 4 Apr 2023 08:47:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PhkgqBI9uXuMpRpH6etF4Qeym94aq9mBqCM693J5aNU=; b=NAWHN7wUNrQzLe kZ0g9ri+cQOD582dAHWkCLkclI6FsgrQoMdIs/vjvOFrv+KLq81mdS+CLILDpsF6zsDn2o0LNNfHv WEKhgq73VAQTBo7quq0pUNEalIAIJlItJQ4ZHI9V8aOtRcIp9nCSOtJ1CeAZtGt+KF+Gs1UdBpvIK zSbXOj6S67tYespNhHKnWBfKq+ZznC5KaKC/iirZcmUExBRPc6mI6uzDJOmoOXdnrpdZ+Qvyd36fv iGbl08/xaIb+kzG9szorbCaJs9PJi96DxlD7fXju+RDJ6NLLim3ammdFE7qLXxbP17CPJAbNhrGW0 43ozOxamcHvYBjdwjWbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pjcKH-000ZCd-1u; Tue, 04 Apr 2023 08:47:38 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pjcI2-000Y4s-0D for linux-rockchip@lists.infradead.org; Tue, 04 Apr 2023 08:45:49 +0000 Received: by mail-ed1-x536.google.com with SMTP id eg48so127364449edb.13 for ; Tue, 04 Apr 2023 01:45:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680597914; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qFniWraH9Zx9AU/nIcDS2ZhpqD+XkT7RdXcaMNk7s1Q=; b=NDZD77ERGU54AP9UX0o03dGSoBhWlpLKC1F1q4/spgOo6ufcp1HxDNMlcs9ACQsg5g if12rdV9irOBZhnU32KKzvVzlnakoLV2M8HJFMZHycBL2tyxRRJglIdqhzJi0BeKuBr7 3o5j7aFQsVplZuwdxXisbDR4gD8sGyzUJfXM1xJV0bqsYok3UsukvOyR6pS9U0VG2alJ +k7+G5jtRkwQL2dWwZ8ukA/TvGors5PwA8qn0S5gLvnl0yNHMz2HzvH8l84W+ZF0t2Id 1PjxnFzuMk48SnEshbFf5lEHfBUCmrcXWupGnPVpbAT25YbnSx1jCkcArKyqhZn12kj1 zsig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680597914; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qFniWraH9Zx9AU/nIcDS2ZhpqD+XkT7RdXcaMNk7s1Q=; b=muViIZfhJ37Nd6CbHt3fwqc8YQLdo6uvnjr+GEKCtu5cPrDm/+eCaSEVICtUQHo2Jv 8vrEwuI5Tp/muf3hj2iH+/+f/ZVwuX3ZJtTgL5unrB7FJzfkIoDE5Z3rJnDNyWt9faNK wO38W7pzYVQMPLV+Zj29DOi04uor5w/5xNwTLX8otxY5bTqa0OBpcZOnaULKBG43fjda YWOPBDBK2h/5hxFGz780VLLgkqBYOKKMyVjEUQwetrQQnYEVz0dMMkJehIMCJqafCFIc pfQ58+uYXqLKADY2J3b7D1nk4jNjZMNmjx5g6BNPJdJ0byn1WKAlwxj264swXWAV6c6n zANg== X-Gm-Message-State: AAQBX9eal6yzz1J31icAcA344HzyRTKWfOe+7auDacachX7ZhPhW3VMv sczz4GePg0teUv5FMkJkJG059g== X-Google-Smtp-Source: AKy350Ys/jY0eQu2PLhBd/9LlS3jfRprWxeYmK085EYvR7AsZb+OPy/s/HlCkHQWIcfQXOxPTxsZ0A== X-Received: by 2002:aa7:d618:0:b0:4af:6c5e:225c with SMTP id c24-20020aa7d618000000b004af6c5e225cmr1829126edr.33.1680597914216; Tue, 04 Apr 2023 01:45:14 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:233a:5c18:b527:381e? ([2a02:810d:15c0:828:233a:5c18:b527:381e]) by smtp.gmail.com with ESMTPSA id r19-20020a50c013000000b004fd29e87535sm5561237edb.14.2023.04.04.01.45.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 01:45:13 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 10:45:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 06/11] dt-bindings: PCI: Update the RK3399 example to a valid one Content-Language: en-US To: Rick Wertenbroek , alberto.dassatti@heig-vd.ch Cc: damien.lemoal@opensource.wdc.com, xxm@rock-chips.com, Shawn Lin , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Heiko Stuebner , Johan Jonker , Brian Norris , Caleb Connolly , Corentin Labbe , Judy Hsiao , Lin Huang , Arnaud Ferraris , Hugh Cole-Baker , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230404082426.3880812-1-rick.wertenbroek@gmail.com> <20230404082426.3880812-7-rick.wertenbroek@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230404082426.3880812-7-rick.wertenbroek@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230404_014519_718373_97080BCF X-CRM114-Status: GOOD ( 17.08 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 04/04/2023 10:24, Rick Wertenbroek wrote: > Update the example in the documentation a valid example. > The default max-outbound-regions is 32 but the example showed 16. This is not reason to be invalid. It is perfectly fine to change default values to desired ones. What is not actually obvious is to change some value to a default one, instead of removing it... > Address for mem-base was invalid. Added pinctrl. > > Signed-off-by: Rick Wertenbroek > --- > .../devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml > index 88386a6d7011..0c67e96096eb 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml > @@ -47,14 +47,15 @@ examples: > > pcie-ep@f8000000 { > compatible = "rockchip,rk3399-pcie-ep"; > - reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0x80000000 0x0 0x20000>; > - reg-names = "apb-base", "mem-base"; Reg (and reg-names) is usually second property, why moving it? What is incorrect in the placement? > + rockchip,max-outbound-regions = <32>; > clocks = <&cru ACLK_PCIE>, <&cru ACLK_PERF_PCIE>, > <&cru PCLK_PCIE>, <&cru SCLK_PCIE_PM>; > clock-names = "aclk", "aclk-perf", > "hclk", "pm"; > max-functions = /bits/ 8 <8>; > num-lanes = <4>; > + reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0xfa000000 0x0 0x2000000>; > + reg-names = "apb-base", "mem-base"; > resets = <&cru SRST_PCIE_CORE>, <&cru SRST_PCIE_MGMT>, > <&cru SRST_PCIE_MGMT_STICKY>, <&cru SRST_PCIE_PIPE> , > <&cru SRST_PCIE_PM>, <&cru SRST_P_PCIE>, <&cru SRST_A_PCIE>; > @@ -62,7 +63,8 @@ examples: > "pm", "pclk", "aclk"; > phys = <&pcie_phy 0>, <&pcie_phy 1>, <&pcie_phy 2>, <&pcie_phy 3>; > phy-names = "pcie-phy-0", "pcie-phy-1", "pcie-phy-2", "pcie-phy-3"; > - rockchip,max-outbound-regions = <16>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pcie_clkreqnb_cpm>; > }; > }; > ... Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip