From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Jonker Subject: Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml Date: Tue, 21 Jan 2020 14:11:02 +0100 Message-ID: References: <20200121123445.29774-1-dafna.hirschfeld@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200121123445.29774-1-dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: dafna.hirschfeld-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org Cc: airlied-cv59FeDIM0c@public.gmane.org, dafna3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, daniel-/w4YWyX8dFk@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, ezequiel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, helen.koike-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, hjc-TNX95d0MmH7DzftRWevZcw@public.gmane.org, kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Hi Dafna, You are checking at the wrong platforms. Maintainers incomplete. ">" is missing. Recheck please. Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml: ignoring, error in schema: maintainers: 0 make ARCH=arm CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- menuconfig # change in menuconfig to Rockchip system make ARCH=arm dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml make ARCH=arm64 defconfig make ARCH=arm64 menuconfig # change in menuconfig to Rockchip platform make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml > From: Dafna Hirschfeld > > convert the binding file rockchip-drm.txt to yaml format. > This was tested and verified with: > make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml > make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml > > Signed-off-by: Dafna Hirschfeld > --- > .../display/rockchip/rockchip-drm.txt | 19 ---------- > .../display/rockchip/rockchip-drm.yaml | 38 +++++++++++++++++++ > 2 files changed, 38 insertions(+), 19 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt > deleted file mode 100644 > index 5707af89319d..000000000000 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.txt > +++ /dev/null > @@ -1,19 +0,0 @@ > -Rockchip DRM master device > -================================ > - > -The Rockchip DRM master device is a virtual device needed to list all > -vop devices or other display interface nodes that comprise the > -graphics subsystem. > - > -Required properties: > -- compatible: Should be "rockchip,display-subsystem" > -- ports: Should contain a list of phandles pointing to display interface port > - of vop devices. vop definitions as defined in > - Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > - > -example: > - > -display-subsystem { > - compatible = "rockchip,display-subsystem"; > - ports = <&vopl_out>, <&vopb_out>; > -}; > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml > new file mode 100644 > index 000000000000..e4ef1a02196d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml > @@ -0,0 +1,38 @@ > +# SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rockchip-drm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip DRM master device > + > +maintainers: > + - Sandy Huang " > + - Heiko Stuebner > + > +description: | > + The Rockchip DRM master device is a virtual device needed to list all > + vop devices or other display interface nodes that comprise the > + graphics subsystem. > + > +properties: > + compatible: > + const: rockchip,display-subsystem > + > + ports: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: | > + Should contain a list of phandles pointing to display interface port > + of vop devices. vop definitions as defined in > + Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > + > +required: > + - compatible > + - ports > + > +examples: > + - | > + display-subsystem { > + compatible = "rockchip,display-subsystem"; > + ports = <&vopl_out>, <&vopb_out>; > + }; > -- > 2.17.1