From: Damon Ding <damon.ding@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>,
hjc@rock-chips.com, andy.yan@rock-chips.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org
Cc: dmitry.baryshkov@oss.qualcomm.com, devicetree@vger.kernel.org,
jonas@kwiboo.se, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, sebastian.reichel@collabora.com,
jernej.skrabec@gmail.com, dianders@chromium.org,
linux-rockchip@lists.infradead.org,
Laurent.pinchart@ideasonboard.com, luca.ceresoli@bootlin.com,
nicolas.frattaroli@collabora.com,
linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH v3 01/10] dt-bindings: display: rockchip: analogix-dp: Expand clock-names "hclk" for the third clock
Date: Fri, 8 May 2026 09:37:09 +0800 [thread overview]
Message-ID: <dd63b7f7-e891-49f1-a795-861d11c55e48@rock-chips.com> (raw)
In-Reply-To: <4528155.7s5MMGUR32@phil>
Hi Heiko,
On 5/7/2026 7:42 PM, Heiko Stuebner wrote:
> Am Donnerstag, 7. Mai 2026, 13:40:09 Mitteleuropäische Sommerzeit schrieb Heiko Stuebner:
>> Hi Damon,
>>
>> Am Donnerstag, 7. Mai 2026, 13:29:39 Mitteleuropäische Sommerzeit schrieb Damon Ding:
>>> The RK3588 eDP controller needs the video datapath clock "hclk" to work
>>> well. Previously, it works without explicitly adding this clock because
>>> the 'rockchip,vo-grf = <&vo1_grf>' property implicitly enables HCLK_VO1.
>>>
>>> Fixes: f855146263b1 ("dt-bindings: display: rockchip: analogix-dp: Add support for RK3588")
>>> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
>>> ---
>>> .../bindings/display/rockchip/rockchip,analogix-dp.yaml | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
>>> index d99b23b88cc5..d2bc8636b626 100644
>>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
>>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
>>> @@ -26,7 +26,9 @@ properties:
>>> items:
>>> - const: dp
>>> - const: pclk
>>> - - const: grf
>>> + - enum:
>>> + - grf
>>> + - hclk
>>
>> are you sure about that?
>>
>> The edp uses the vo1-grf - so what enables its clock?
>> For example the hdmi controllers on rk3588 also use the vo1-grf and
>> explicitly handle that clock.
>>
>> So who does it for the eDP?
>
> Ah, ... found the hclk_vo1 in the following patches.
>
> Still the binding commit message could use some more words about what that
> clock is, and why it can "replace" the GRF clock from earlier SoCs.
>
>
Yes, I will add more descriptions about this in next version. :-)
Best regards,
Damon
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-05-08 1:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 11:29 [PATCH v3 00/10] Add eDP support for RK3576 Damon Ding
2026-05-07 11:29 ` [PATCH v3 01/10] dt-bindings: display: rockchip: analogix-dp: Expand clock-names "hclk" for the third clock Damon Ding
2026-05-07 11:40 ` Heiko Stuebner
2026-05-07 11:42 ` Heiko Stuebner
2026-05-08 1:37 ` Damon Ding [this message]
2026-05-07 11:29 ` [PATCH v3 02/10] dt-bindings: display: rockchip: analogix-dp: Add descriptions for clocks Damon Ding
2026-05-07 11:29 ` [PATCH v3 03/10] arm64: dts: rockchip: Add missing clock "hclk" for RK3588 eDP0 nodes Damon Ding
2026-05-07 11:29 ` [PATCH v3 04/10] arm64: dts: rockchip: Add missing clock "hclk" for RK3588 eDP1 nodes Damon Ding
2026-05-07 11:29 ` [PATCH v3 05/10] drm/rockchip: analogix_dp: Enable clock "hclk" for RK3588 Damon Ding
2026-05-07 11:29 ` [PATCH v3 06/10] dt-bindings: display: rockchip: analogix-dp: Add support for RK3576 Damon Ding
2026-05-07 11:29 ` [PATCH v3 07/10] arm64: dts: rockchip: Add eDP node " Damon Ding
2026-05-07 11:29 ` [PATCH v3 08/10] drm/bridge: analogix_dp: Rename and simplify is_rockchip() Damon Ding
2026-05-07 11:29 ` [PATCH v3 09/10] drm/bridge: analogix_dp: Add support for RK3576 Damon Ding
2026-05-07 11:29 ` [PATCH v3 10/10] drm/rockchip: " Damon Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd63b7f7-e891-49f1-a795-861d11c55e48@rock-chips.com \
--to=damon.ding@rock-chips.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox