From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH v6 6/6] drm/bridge: add PHY initialization in mhdp8546 driver. Date: Wed, 7 Nov 2018 12:49:30 +0100 Message-ID: References: <1539034953-11274-1-git-send-email-dkos@cadence.com> <1539034953-11274-7-git-send-email-dkos@cadence.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1539034953-11274-7-git-send-email-dkos@cadence.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Damian Kos , David Airlie , Rob Herring , Mark Rutland , Archit Taneja , Laurent Pinchart , Gustavo Padovan , Maarten Lankhorst , Sean Paul , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Quentin Schulz , Piotr Sroka , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Cc: rafalc@cadence.com, quentin.schulz@bootlin.com, jbergsagel@ti.com List-Id: linux-rockchip.vger.kernel.org On 08.10.2018 23:42, Damian Kos wrote: > This patch modifies the mhdp8546 driver to initialize sd0801 "Torrent" PHY. > > And removes the dbg_regs field from cdns_mhdp_device structure. > > Signed-off-by: Damian Kos > --- > drivers/gpu/drm/bridge/cdns-mhdp.c | 9 +++++++++ > include/drm/bridge/cdns-mhdp-common.h | 1 - > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/cdns-mhdp.c b/drivers/gpu/drm/bridge/cdns-mhdp.c > index 48ac5cf1e031..caaf3c17d74f 100644 > --- a/drivers/gpu/drm/bridge/cdns-mhdp.c > +++ b/drivers/gpu/drm/bridge/cdns-mhdp.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -1220,6 +1221,12 @@ static int mhdp_probe(struct platform_device *pdev) > if (IS_ERR(mhdp->regs)) > return PTR_ERR(mhdp->regs); > > + mhdp->phy = devm_phy_get(&pdev->dev, "dpphy"); It is not documented in the bindings. > + if (IS_ERR(mhdp->phy)) { > + dev_err(&pdev->dev, "no PHY configured\n"); dev_err only if err != -EPROBE_DEFER > + return PTR_ERR(mhdp->phy); > + } > + > platform_set_drvdata(pdev, mhdp); > > ret = load_firmware(mhdp, FW_NAME, CDNS_MHDP_IMEM); > @@ -1291,6 +1298,8 @@ static int mhdp_probe(struct platform_device *pdev) > mhdp->dev, HDMI_CODEC_DRV_NAME, PLATFORM_DEVID_AUTO, > &codec_data, sizeof(codec_data)); > > + phy_init(mhdp->phy); > + Beside this: Reviewed-by: Andrzej Hajda  -- Regards Andrzej > /* Enable VIF clock for stream 0 */ > cdns_mhdp_reg_read(mhdp, CDNS_DPTX_CAR, &resp); > cdns_mhdp_reg_write(mhdp, CDNS_DPTX_CAR, > diff --git a/include/drm/bridge/cdns-mhdp-common.h b/include/drm/bridge/cdns-mhdp-common.h > index d4711091ff2b..1e8a44138ce2 100644 > --- a/include/drm/bridge/cdns-mhdp-common.h > +++ b/include/drm/bridge/cdns-mhdp-common.h > @@ -553,7 +553,6 @@ struct cdns_mhdp_device { > struct cdns_mhdp_sink sink; > struct cdns_mhdp_bridge bridge; > struct phy *phy; > - void __iomem *dbg_regs; > > struct video_info video_info; > struct drm_display_mode mode;