Re: [PATCH v7 4/6] media: platform: synopsys: Add support for HDMI input driver

From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: "Markus Elfring" <Markus.Elfring@web.de>,
	"Dingxian Wen" <shawn.wen@rock-chips.com>,
	"Shreeya Patel" <shreeya.patel@collabora.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Hans Verkuil" <hverkuil@xs4all.nl>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Jose Abreu" <Jose.Abreu@synopsys.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Nelson Costa" <Nelson.Costa@synopsys.com>,
	"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
	"Rob Herring" <robh@kernel.org>,
	"Sebastian Reichel" <sebastian.reichel@collabora.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel@collabora.com, Tim Surber <me@timsurber.de>
Subject: Re: [PATCH v7 4/6] media: platform: synopsys: Add support for HDMI input driver
Date: Sun, 23 Feb 2025 00:25:18 +0300	[thread overview]
Message-ID: <dfb0ef63-8867-4d00-abdd-8280623c3405@collabora.com> (raw)
In-Reply-To: <9e46e0f9-ef0d-406f-9fa9-9c4464a8db88@web.de>

On 2/19/25 23:56, Markus Elfring wrote:
> …
>> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>> @@ -0,0 +1,2718 @@
> …
>> +static u32 hdmirx_readl(struct snps_hdmirx_dev *hdmirx_dev, int reg)
>> +{
>> +	u32 val;
>> +
>> +	guard(spinlock_irqsave)(&hdmirx_dev->rst_lock);
>> +
>> +	val = readl(hdmirx_dev->regs + reg);
>> +
>> +	return val;
>> +}
> 
> May such a function implementation be simplified?
> 
> {
> 	guard(spinlock_irqsave)(&hdmirx_dev->rst_lock);
> 	return readl(hdmirx_dev->regs + reg);
> }

That will work, thanks.

> …
>> +static int hdmirx_get_detected_timings(struct snps_hdmirx_dev *hdmirx_dev,
>> +				       struct v4l2_dv_timings *timings)
>> +{
> …
>> +	mutex_lock(&hdmirx_dev->work_lock);
>> +retry:
>> +	memset(timings, 0, sizeof(struct v4l2_dv_timings));
> …
>> +	mutex_unlock(&hdmirx_dev->work_lock);
>> +
>> +	return ret;
>> +}
> …
> 
> Would you become interested to apply a statement like “guard(mutex)(&hdmirx_dev->work_lock);”?
> https://elixir.bootlin.com/linux/v6.14-rc3/source/include/linux/mutex.h#L201

That will make code less consistent and less intuitive to me. Anyways,
thanks for the suggestion.

-- 
Best regards,
Dmitry

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip