Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

From: Kever Yang <kever.yang@rock-chips.com>
To: Sandy Huang <hjc@rock-chips.com>,
	heiko@sntech.de,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>,
	huangtao@rock-chips.com, andy.yan@rock-chips.com,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
Date: Mon, 19 Oct 2020 11:43:53 +0800	[thread overview]
Message-ID: <e016801a-61aa-de6c-cb90-c62e03bdd067@rock-chips.com> (raw)
In-Reply-To: <20201015152301.GE438822@phenom.ffwll.local>

Hi Daniel,

On 2020/10/15 下午11:23, Daniel Vetter wrote:
> On Wed, Oct 14, 2020 at 09:48:43AM +0800, Kever Yang wrote:
>> Hi Maintainers,
>>
>>      Does this patch ready to merge?
> Would maybe be good to get some acks from other drivers using this, then
> Sandy can push to drm-misc-next.

Thanks for your reply, I can understand more 'acks' will be better, but 
there is no comments object to this patch

or any 'NAK' common for more then 3 months, maintainers should move to 
next step.

Thanks,

- Kever

> -Daniel
>> On 2020/7/7 下午7:25, Sandy Huang wrote:
>>> don't mask possible_crtcs if remote-point is disabled.
>>>
>>> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
>>> ---
>>>    drivers/gpu/drm/drm_of.c | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
>>> index fdb05fbf72a0..565f05f5f11b 100644
>>> --- a/drivers/gpu/drm/drm_of.c
>>> +++ b/drivers/gpu/drm/drm_of.c
>>> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
>>>    	uint32_t possible_crtcs = 0;
>>>    	for_each_endpoint_of_node(port, ep) {
>>> +		if (!of_device_is_available(ep))
>>> +			continue;
>>> +
>>>    		remote_port = of_graph_get_remote_port(ep);
>>>    		if (!remote_port) {
>>>    			of_node_put(ep);
>> Looks good to me.
>>
>>
>> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip