Re: [RFC PATCH 2/3] arm64: dts: rockchip: rk356x: add LVDS bindings

["Sverdlin, Alexander" <alexander.sverdlin@siemens.com>]

Hello Alibek!

On Fri, 2022-09-23 at 19:01 +0300, Alibek Omarov wrote:
> > Exposes ports for VOP2 and for panel
> > 
> > Signed-off-by: Alibek Omarov <a1ba.omarov@gmail.com>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk356x.dtsi | 25 >
> > ++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi >
> > b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> > index 0473d7ee2668..fea3319a6a4e 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> > @@ -787,6 +787,31 @@ hdmi_out: port@1 {
> >                 };
> >         };
> >  
> > +       lvds: lvds {
> > +               compatible = "rockchip,rk3568-lvds";
> > +               clocks = <&cru PCLK_DSITX_0>;
> > +               clock-names = "pclk_lvds";
> > +               phys = <&dsi_dphy0>;

If this patch depends of the 
https://lore.kernel.org/all/20220906174823.28561-6-macroalpha82@gmail.com/
patch, then should the phys reference "mipi_dphy0" node?

> > +               phy-names = "dphy";
> > +               power-domains = <&power RK3568_PD_VO>;
> > +               rockchip,grf = <&grf>;
> > +               rockchip,output = "lvds";
> > +               status = "disabled";
> > +
> > +               ports {
> > +                       #address-cells = <1>;
> > +                       #size-cells = <0>;
> > +
> > +                       lvds_in: port@0 {
> > +                               reg = <0>;
> > +                       };
> > +
> > +                       lvds_out: port@1 {
> > +                               reg = <1>;
> > +                       };
> > +               };
> > +       };
> > +
> >         qos_gpu: qos@fe128000 {
> >                 compatible = "rockchip,rk3568-qos", "syscon";
> >                 reg = <0x0 0xfe128000 0x0 0x20>;

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip