Re: [PATCH v2 06/12] staging: media: rkvdec: Add a valid pixel format check as callback

Ezequiel Garcia
2023-01-12T15:32:28Z

Hi Sebastian,

On Thu, Jan 12, 2023 at 9:56 AM Sebastian Fricke
<sebastian.fricke@collabora.com> wrote:
>
> Provide a callback for codec variant drivers to indicate the correct
> output pixel-format. It will either utilize the SPS structure stored via
> the S_CTRL IOCTL or return the default pixel-format.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>
> ---
> drivers/staging/media/rkvdec/rkvdec.c | 45 +++++++++++++++++++++++++++++------
> drivers/staging/media/rkvdec/rkvdec.h | 1 +
> 2 files changed, 39 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/media/rkvdec/rkvdec.c
> index e0e95d06e216..a46f918926a2 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.c
> +++ b/drivers/staging/media/rkvdec/rkvdec.c
> @@ -38,6 +38,20 @@ static int rkvdec_queue_busy(struct rkvdec_ctx *ctx, enum v4l2_buf_type buf_type
> return 0;
> }
>
> +/*
> + * Use the current SPS, set by the user via the VIDIOC_S_CTRL IOCTL,
> + * to determine the optimal pixel-format. Each codec is responsible
> + * for choosing the appropriate pixel-format for a given parameter set.
> + */

It seems this assumes there's always only one valid format.
Do you think that will hold true always for RKVDEC and for all codecs?

How about we approach this differently? Instead of having a callback
for codecs to implement, we just maintain a list of valid decoded formats
(in the context) and re-create the list when the SPS is changed (in the S_CTRL).

Possibly simpler and less invasive, not sure if there are any caveats.

Thanks,
Ezequiel

> +static int rkvdec_get_valid_fmt(struct rkvdec_ctx *ctx)
> +{
> + const struct rkvdec_coded_fmt_desc *coded_desc = ctx->coded_fmt_desc;
> +
> + if (coded_desc->ops->valid_fmt)
> + return coded_desc->ops->valid_fmt(ctx);
> + return ctx->coded_fmt_desc->decoded_fmts[0];
> +}
> +
> static int rkvdec_try_ctrl(struct v4l2_ctrl *ctrl)
> {
> struct rkvdec_ctx *ctx = container_of(ctrl->handler, struct rkvdec_ctx, ctrl_hdl);
> @@ -200,8 +214,9 @@ static void rkvdec_reset_coded_fmt(struct rkvdec_ctx *ctx)
> static void rkvdec_reset_decoded_fmt(struct rkvdec_ctx *ctx)
> {
> struct v4l2_format *f = &ctx->decoded_fmt;
> + u32 valid_fmt = rkvdec_get_valid_fmt(ctx);
>
> - rkvdec_reset_fmt(ctx, f, ctx->coded_fmt_desc->decoded_fmts[0]);
> + rkvdec_reset_fmt(ctx, f, valid_fmt);
> f->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;
> v4l2_fill_pixfmt_mp(&f->fmt.pix_mp,
> ctx->coded_fmt_desc->decoded_fmts[0],
> @@ -260,13 +275,17 @@ static int rkvdec_try_capture_fmt(struct file *file, void *priv,
> if (WARN_ON(!coded_desc))
> return -EINVAL;
>
> - for (i = 0; i < coded_desc->num_decoded_fmts; i++) {
> - if (coded_desc->decoded_fmts[i] == pix_mp->pixelformat)
> - break;
> - }
> + if (ctx->sps) {
> + pix_mp->pixelformat = rkvdec_get_valid_fmt(ctx);
> + } else {
> + for (i = 0; i < coded_desc->num_decoded_fmts; i++) {
> + if (coded_desc->decoded_fmts[i] == pix_mp->pixelformat)
> + break;
> + }
>
> - if (i == coded_desc->num_decoded_fmts)
> - pix_mp->pixelformat = coded_desc->decoded_fmts[0];
> + if (i == coded_desc->num_decoded_fmts)
> + pix_mp->pixelformat = coded_desc->decoded_fmts[0];
> + }
>
> /* Always apply the frmsize constraint of the coded end. */
> pix_mp->width = max(pix_mp->width, ctx->coded_fmt.fmt.pix_mp.width);
> @@ -435,6 +454,18 @@ static int rkvdec_enum_capture_fmt(struct file *file, void *priv,
> if (WARN_ON(!ctx->coded_fmt_desc))
> return -EINVAL;
>
> + /*
> + * According to the specification the driver can only return formats
> + * that are supported by both the current encoded format and the
> + * provided controls
> + */
> + if (ctx->sps) {
> + if (f->index)
> + return -EINVAL;
> + f->pixelformat = rkvdec_get_valid_fmt(ctx);
> + return 0;
> + }
> +
> if (f->index >= ctx->coded_fmt_desc->num_decoded_fmts)
> return -EINVAL;
>
> diff --git a/drivers/staging/media/rkvdec/rkvdec.h b/drivers/staging/media/rkvdec/rkvdec.h
> index 332126e7b812..e353a4403e5b 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.h
> +++ b/drivers/staging/media/rkvdec/rkvdec.h
> @@ -66,6 +66,7 @@ vb2_to_rkvdec_decoded_buf(struct vb2_buffer *buf)
> struct rkvdec_coded_fmt_ops {
> int (*adjust_fmt)(struct rkvdec_ctx *ctx,
> struct v4l2_format *f);
> + u32 (*valid_fmt)(struct rkvdec_ctx *ctx);
> int (*start)(struct rkvdec_ctx *ctx);
> void (*stop)(struct rkvdec_ctx *ctx);
> int (*run)(struct rkvdec_ctx *ctx);
>
> --
> 2.25.1