From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Subject: Re: [PATCH v5 5/5] mmc: sdhci-of-arasan: implement enhanced strobe callback Date: Tue, 24 May 2016 09:55:05 +0800 Message-ID: References: <1463976789-29618-1-git-send-email-shawn.lin@rock-chips.com> <1463976853-29862-1-git-send-email-shawn.lin@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org To: Doug Anderson Cc: shawn.lin@rock-chips.com, Ulf Hansson , Adrian Hunter , Jaehoon Chung , Michal Simek , soren.brinkmann@xilinx.com, Rob Herring , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Brian Norris , Heiko Stuebner , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" List-Id: linux-rockchip.vger.kernel.org =E5=9C=A8 2016/5/24 5:00, Doug Anderson =E5=86=99=E9=81=93: > Shawn, > > On Sun, May 22, 2016 at 9:14 PM, Shawn Lin = wrote: >> Currently sdhci-arasan 5.1 can support enhanced strobe function, >> and we now limit it just for "arasan,sdhci-5.1". Add >> mmc-hs400-enhanced-strobe in DT to enable the function if we're >> sure our controller can support it. >> >> Signed-off-by: Shawn Lin >> Acked-by: Adrian Hunter >> Reviewed-by: Doug Anderson >> --- >> >> Changes in v5: None >> Changes in v4: None > > Again, minor, but you did have changes... yes, it did. I moved all the change-log into the cover-letter but it seems better to keep them seperately for each patch. I will do it for the next version if needed. Thanks. > >> Changes in v3: None >> Changes in v2: None >> >> drivers/mmc/host/sdhci-of-arasan.c | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) > > I've tested this patch and it appears to work (not that I've hooked a > scope up, but since it's not doing tuning I think it would be pretty > obvious if it didn't work). > > Tested-by: Douglas Anderson > > > --=20 Best Regards Shawn Lin