From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH v3 4/5] thermal: rockchip: optimize the conversion table Date: Mon, 12 Dec 2016 18:48:53 +0800 Message-ID: References: <1480331524-18741-1-git-send-email-wxt@rock-chips.com> <1480331524-18741-5-git-send-email-wxt@rock-chips.com> <20161130062911.GB28498@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20161130062911.GB28498@localhost.localdomain> Sender: linux-pm-owner@vger.kernel.org To: Eduardo Valentin , Caesar Wang Cc: heiko@sntech.de, linux-pm@vger.kernel.org, briannorris@chromium.org, linux-kernel@vger.kernel.org, smbarber@chromium.org, linux-rockchip@lists.infradead.org, rui.zhang@intel.com List-Id: linux-rockchip.vger.kernel.org 在 2016年11月30日 14:29, Eduardo Valentin 写道: > Hey, > > On Mon, Nov 28, 2016 at 07:12:03PM +0800, Caesar Wang wrote: > > > >> + num = abs(table->id[mid].code - table->id[mid + 1].code); >> + num *= temp - table->id[mid].temp; >> + denom = table->id[mid + 1].temp - table->id[mid].temp; > > isn't the above 'mid + 1' off-by-one when mid ends being == table.length - 1? > > You would be accessing table->id[table.length], which is wrong memory > access, no? Yup, that's indeed a real issue for me. FIxes on next version. Thanks. -Caesar > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip