Re: [PATCH v2 3/4] PCI: dw-rockchip: Replace PERST sleep time with proper macro

From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
To: "robh@kernel.org" <robh@kernel.org>,
	"kw@linux.com" <kw@linux.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"cassel@kernel.org" <cassel@kernel.org>,
	"manivannan.sadhasivam@linaro.org"
	<manivannan.sadhasivam@linaro.org>,
	"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
	"heiko@sntech.de" <heiko@sntech.de>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"laszlo.fiat@proton.me" <laszlo.fiat@proton.me>,
	"dlemoal@kernel.org" <dlemoal@kernel.org>,
	"18255117159@163.com" <18255117159@163.com>,
	"linux-rockchip@lists.infradead.org"
	<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v2 3/4] PCI: dw-rockchip: Replace PERST sleep time with proper macro
Date: Tue, 6 May 2025 22:24:45 +0000	[thread overview]
Message-ID: <e6357b42ae1506729bc7fb07eb8df05e87a59d4e.camel@wdc.com> (raw)
In-Reply-To: <20250506073934.433176-9-cassel@kernel.org>

On Tue, 2025-05-06 at 09:39 +0200, Niklas Cassel wrote:
> Replace the PERST sleep time with the proper macro
> (PCIE_T_PVPERL_MS).
> No functional change.
> 
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
>  drivers/pci/controller/dwc/pcie-dw-rockchip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> index 6a7ec3545a7f..0baf9da3ac1c 100644
> --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c
> @@ -225,7 +225,7 @@ static int rockchip_pcie_start_link(struct
> dw_pcie *pci)
>  	 * We need more extra time as before, rather than setting
> just
>  	 * 100us as we don't know how long should the device need to
> reset.
>  	 */
> -	msleep(100);
> +	msleep(PCIE_T_PVPERL_MS);
>  	gpiod_set_value_cansleep(rockchip->rst_gpio, 1);
>  
>  	return 0;
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip