From: Dragan Simic <dsimic@manjaro.org>
To: FUKAUMI Naoki <naoki@radxa.com>
Cc: heiko@sntech.de, robh@kernel.org, conor+dt@kernel.org,
inindev@gmail.com, devicetree@vger.kernel.org,
sebastian.reichel@collabora.com,
linux-rockchip@lists.infradead.org, alchark@gmail.com,
krzk+dt@kernel.org
Subject: Re: [PATCH v2 0/4] arm64: dts: rockchip: cosmetic changes for Radxa ROCK 5B
Date: Mon, 02 Dec 2024 04:06:42 +0100 [thread overview]
Message-ID: <e981c540fe086313ad6ef6fcba62eeaf@manjaro.org> (raw)
In-Reply-To: <20241202023227.2671-1-naoki@radxa.com>
Hello Fukaumi,
On 2024-12-02 03:32, FUKAUMI Naoki wrote:
> this patch series sort nodes and properties, remove redundant
> properties, and minor cosmetic changes.
>
> no functional change is intended.
>
> this patch series depend on following patch series:
> "arm64: dts: rockchip: sync dts with schematic for Radxa ROCK 5B"
>
> https://patchwork.kernel.org/project/linux-rockchip/cover/20241130004057.7432-1-naoki@radxa.com/
>
> FUKAUMI Naoki (4):
> arm64: dts: rockchip: sort nodes in .dts for Radxa ROCK 5B
> arm64: dts: rockchip: sort nodes in root node for Radxa ROCK 5B
> arm64: dts: rockchip: sort properties in .dts for Radxa ROCK 5B
> arm64: dts: rockchip: cosmetic changes for Radxa ROCK 5B
>
> .../boot/dts/rockchip/rk3588-rock-5b.dts | 184 ++++++++----------
> 1 file changed, 86 insertions(+), 98 deletions(-)
I'd suggest that you expand the descriptions of all four patches
in this series. The way they're currently written leaves a lot of
room for improvement, such as turning them into proper sentences
and expanding the wording to describe the intent and nature of the
introduced changes better.
The cover letter surely provides an additional explanation for
the entire series, but please note that only the patch descriptions
can find their way into the repository, so each patch description
needs to be self-contained and independent of the cover letter and
the descriptions of other patches in the series.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-12-02 3:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 2:32 [PATCH v2 0/4] arm64: dts: rockchip: cosmetic changes for Radxa ROCK 5B FUKAUMI Naoki
2024-12-02 2:32 ` [PATCH v2 1/4] arm64: dts: rockchip: sort nodes in .dts " FUKAUMI Naoki
2024-12-02 2:32 ` [PATCH v2 2/4] arm64: dts: rockchip: sort nodes in root node " FUKAUMI Naoki
2024-12-02 2:32 ` [PATCH v2 3/4] arm64: dts: rockchip: sort properties in .dts " FUKAUMI Naoki
2024-12-02 2:32 ` [PATCH v2 4/4] arm64: dts: rockchip: cosmetic changes " FUKAUMI Naoki
2024-12-02 3:06 ` Dragan Simic [this message]
2024-12-02 3:58 ` [PATCH v2 0/4] " FUKAUMI Naoki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e981c540fe086313ad6ef6fcba62eeaf@manjaro.org \
--to=dsimic@manjaro.org \
--cc=alchark@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=inindev@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox