From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH] iommu: rockchip: Drop verbose prints in the interrupt handler Date: Wed, 26 Sep 2018 19:31:22 +0200 Message-ID: References: <20180830222832.16766-1-ezequiel@collabora.com> <20180925112930.u5kftmo3vhmdxji4@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180925112930.u5kftmo3vhmdxji4-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel , Marc Zyngier Cc: Heiko Stuebner , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, enric.balletbo-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org, kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org On Tue, 2018-09-25 at 13:29 +0200, Joerg Roedel wrote: > On Thu, Aug 30, 2018 at 07:28:32PM -0300, Ezequiel Garcia wrote: > > Printing verbosely via WARN macros and friends in interrupt handlers > > is strongly discouraged. Drop them and use proper ratelimited > > prints. > > > > Signed-off-by: Ezequiel Garcia > > --- > > drivers/iommu/rockchip-iommu.c | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > This doesn't apply cleanly to v4.19-rc5, can you please base the patch > on that tag, add the Reviewed-by and re-send? > Well, after looking at the latest code, now I'm wondering why Marc changed the WARN_ON with a WARN_ON_ONCE, instead of a less verbose ratelimited print.