public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Johan Jonker <jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: Re: [PATCH] arm64: dts: rockchip: add ROCK Pi S DTS support
Date: Mon, 16 Dec 2019 10:20:55 +0100	[thread overview]
Message-ID: <ea6d2f0d-450c-f0ee-6150-65a6855b7546@gmail.com> (raw)
In-Reply-To: <20191215173318.16385-1-akash-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>

Hi Akash,

See commit below.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-S.dts b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-S.dts
> new file mode 100644
> index 000000000000..e5fae451c631
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-S.dts


> +
> +&emmc {
> +	bus-width = <4>;
> +	cap-mmc-highspeed;
> +	mmc-hs200-1_8v;
> +	supports-sd;

> +	disable-wp;

The mmc.txt didn't explicitly say disable-wp is for SD card slot only,
but that is what it was designed for in the first place.
Remove all disable-wp from emmc or sdio controllers.

> +	non-removable;
> +	num-slots = <1>;
> +	vin-supply = <&vcc_io>;
> +	status = "okay";
> +};

> +
> +&sdmmc {
> +	bus-width = <4>;
> +	cap-mmc-highspeed;
> +	cap-sd-highspeed;
> +	max-frequeency = <150000000>;
> +	supports-sd;
> +	disable-wp;
> +	num-slots = <1>;
> +	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_det &sdmmc_bus4>;
> +	card-detect-delay = <800>;
> +	status = "okay";
> +};

  parent reply	other threads:[~2019-12-16  9:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-15 17:33 [PATCH] arm64: dts: rockchip: add ROCK Pi S DTS support Akash Gajjar
2019-12-15 17:50 ` akash
2019-12-16  2:47 ` Andy Yan
     [not found] ` <20191215173318.16385-1-akash-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org>
2019-12-16  9:20   ` Johan Jonker [this message]
     [not found]     ` <ea6d2f0d-450c-f0ee-6150-65a6855b7546-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-12-16 10:48       ` Johan Jonker
     [not found]         ` <31424b70-bbe1-f2ab-13ee-b1653beab049-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-12-16 11:25           ` Johan Jonker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea6d2f0d-450c-f0ee-6150-65a6855b7546@gmail.com \
    --to=jbx6244-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox