Re: [PATCH v3 21/22] drm/amdgpu: Provide ddc symlink in connector sysfs directory

Andrzej Pietrasiewicz
2019-07-04T13:17:01Z

W dniu 02.07.2019 o 22:54, Alex Deucher pisze:
> On Fri, Jun 28, 2019 at 12:31 PM Andrzej Pietrasiewicz
> <andrzej.p@collabora.com> wrote:
>>
>> Use the ddc pointer provided by the generic connector.
>>
>> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
>> ---
>> .../gpu/drm/amd/amdgpu/amdgpu_connectors.c | 70 ++++++++++++++-----
>> 1 file changed, 51 insertions(+), 19 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>> index 73b2ede773d3..5f8a7e3818b9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
>> @@ -1573,11 +1573,15 @@ amdgpu_connector_add(struct amdgpu_device *adev,
>> goto failed;
>> amdgpu_connector->con_priv = amdgpu_dig_connector;
>> if (i2c_bus->valid) {
>> - amdgpu_connector->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
>> - if (amdgpu_connector->ddc_bus)
>> + struct amdgpu_connector *acn = amdgpu_connector;
>> +
>> + acn->ddc_bus = amdgpu_i2c_lookup(adev, i2c_bus);
>> + if (acn->ddc_bus) {
>
> This hunk seems pointless unless I'm missing something. Can you drop
> this hunk? Same comment on each instance of this below. This also
> only covers the legacy modesetting code which is not used by default
> on most chips. The DC code in amd/display/ is probably more relevant.
>

If I don't do that checkpatch reports that lines I created exceed 80 characters.

Andrzej
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org