From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v4 1/7] dt-bindings: Add panel-timing subnode to simple-panel Date: Thu, 28 Mar 2019 17:26:49 -0300 Message-ID: References: <20190328171710.31949-1-dianders@chromium.org> <20190328171710.31949-2-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190328171710.31949-2-dianders@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Douglas Anderson , Thierry Reding , Heiko Stuebner , Sean Paul Cc: linux-rockchip@lists.infradead.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, Boris Brezillon , Enric =?ISO-8859-1?Q?Balletb=F2?= , Rob Herring , mka@chromium.org, Eric Anholt , Jeffy Chen , =?ISO-8859-1?Q?St=E9phane?= Marchesin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, David Airlie , Mark Rutland , Daniel Vetter List-Id: linux-rockchip.vger.kernel.org On Thu, 2019-03-28 at 10:17 -0700, Douglas Anderson wrote: > From: Sean Paul > > This patch adds a new subnode to simple-panel allowing us to override > the typical timing expressed in the panel's display_timing. > > Changes in v2: > - Split out the binding into a new patch (Rob) > - display-timings is a new section (Rob) > - Use the full display-timings subnode instead of picking the timing > out (Rob/Thierry) > Changes in v3: > - Go back to using the timing subnode directly, but rename to > panel-timing (Rob) > Changes in v4: > - Simplify desc. for when override should be used (Thierry/Laurent) > - Removed Rob H review since it's been a year and wording changed > > Cc: Doug Anderson > Cc: Eric Anholt > Cc: Heiko Stuebner > Cc: Jeffy Chen > Cc: Rob Herring > Cc: Stéphane Marchesin > Cc: Thierry Reding > Cc: devicetree@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-rockchip@lists.infradead.org > Signed-off-by: Sean Paul > Signed-off-by: Douglas Anderson > --- > > .../bindings/display/panel/simple-panel.txt | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/simple-panel.txt b/Documentation/devicetree/bindings/display/panel/simple-panel.txt > index b2b872c710f2..6157f86ddce4 100644 > --- a/Documentation/devicetree/bindings/display/panel/simple-panel.txt > +++ b/Documentation/devicetree/bindings/display/panel/simple-panel.txt > @@ -15,6 +15,18 @@ Optional properties: > (hot plug detect) signal, but the signal isn't hooked up so we should > hardcode the max delay from the panel spec when powering up the panel. > > +panel-timing subnode > +-------------------- > + > +This optional subnode is for devices which require a mode differing > +from the panel's "typical" display timing. The panel timings provided > +here will be ignored if they are found to be outside of allowable > +ranges for the given panel. > + Is it OK to put this comment about how the implementation will behave when values are out of range, given this is just a binding spec? Perhaps -if needed- this sentence can be rephrased to state that, e.g. the OS may not be able to apply these values, if the controller or device is unable to? > +Format information on the panel-timing subnode can be found in > +display-timing.txt. > + > + > Example: > > panel: panel { > @@ -25,4 +37,16 @@ Example: > enable-gpios = <&gpio 90 0>; > > backlight = <&backlight>; > + > + panel-timing { > + clock-frequency = <266604720>; > + hactive = <2400>; > + hfront-porch = <48>; > + hback-porch = <84>; > + hsync-len = <32>; > + vactive = <1600>; > + vfront-porch = <3>; > + vback-porch = <120>; > + vsync-len = <10>; > + }; > };