From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C567DC71157 for ; Wed, 18 Jun 2025 15:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KOFnnuz3qgEYfi52ifRwjfBRi6uLyQawNkheSnEF8wg=; b=wTI09faZ5E9VNC rBQcY6oZcqKOA8wptra/nSTD9cc6iJ/wXfiiinnafz2h7mxlCrPn0XOD8k4LL2jWMdfv6uXm2qCi7 Ity+Xm0w2c58To9I2Kg5RwPVmFW0ci54rmm2jYLbHJbQ54a8aYltplp5bM6ovwMcnbkZ3HpHFGofl rScWjJy3Wafjb6Av0oLUoHXWpqXvTWeObzHmQcdYl9IqiZ/YxNU32NlbHnNcifucraV+pCuDvuzKX gK4Kc9kMiAoiSELvxjLNlba/nP6UvthLdLxHN7/nU1fPsObBVKiQKZDbkKlC9dnQAtR65vJ9/2V5u kHCGTU43WbH45vy8JUCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRugx-0000000Aaq9-3chw; Wed, 18 Jun 2025 15:27:11 +0000 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRt1B-0000000AKgU-3t1I; Wed, 18 Jun 2025 13:39:59 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id C06BA443BC; Wed, 18 Jun 2025 13:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1750253994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dgrZOfyKtBkV3FRP+QW5pRebwqcUGFtff5SNDuOzWCw=; b=cBeCCwRWYKaXrBWXnieTF9Lfp7GlUSilFf3D5MOrwR7vnJVlg5HIUhkC4zaiFnlWTAm9pt GAci5crFZVOTHAu3pJztu6OxNsxECwMEcTHUR5zObr1EwCJL309nrgq4bT2gcgPD0ifOJY exIlKTj/XxkUd3AvNQOxf8nKoo8G1+NX1zT3wZ/dpJZ3dNSmuWYY+k6gJpLeUndPCUN8X5 +0CJjy1KlZKlQuF3Ich9hVSrUhk42XprvvFWcqFfd9ubPl+ztpvQD65lxZmW4FGLv9WFnx K8/XeLDm1PCfp7vS1N00WMHj6jXLw7MAPtC7YubzDJMppH/OwP5cVoQUZkNnCQ== Message-ID: Date: Wed, 18 Jun 2025 15:39:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Remove unused property in PinePhone Pro MIPI panel To: Diederik de Haas , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Thomas Petazzoni , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250618-dtb_fixes-v1-0-e54797ad2eba@bootlin.com> <20250618-dtb_fixes-v1-3-e54797ad2eba@bootlin.com> Content-Language: en-US From: Olivier Benjamin In-Reply-To: X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgddvjeekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepqfhlihhvihgvrhcuuegvnhhjrghmihhnuceoohhlihhvihgvrhdrsggvnhhjrghmihhnsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpedvheejtdeifeejvedvffdtuddtheehtdelvdehvefgjeetveejfeeiveduvdejteenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucfkphepvdgrtddumegvfeegmegvtgefkeemvdegvgdtmehfhegtvgemfhefgedvmeeiheekjeemfheiheeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdgrtddumegvfeegmegvtgefkeemvdegvgdtmehfhegtvgemfhefgedvmeeiheekjeemfheiheeipdhhvghloheplgfkrfggieemvdgrtddumegvfeegmegvtgefkeemvdegvgdtmehfhegtvgemfhefgedvmeeiheekjeemfheiheeingdpmhgrihhlfhhrohhmpeholhhivhhivghrrdgsvghnjhgrmhhinhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepuddtpdhrtghpthhtohepughiughirdguvggsihgrnhestghknhhofidrohhrghdprhgtphhtthhop ehrohgshheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepkhhriihkodgutheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheptghonhhorhdoughtsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehhvghikhhosehsnhhtvggthhdruggvpdhrtghpthhtohepthhhohhmrghsrdhpvghtrgiiiihonhhisegsohhothhlihhnrdgtohhmpdhrtghpthhtohepuggvvhhitggvthhrvggvsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhg X-GND-Sasl: olivier.benjamin@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250618_063958_587902_DDC2376E X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 6/18/25 14:12, Diederik de Haas wrote: > Hi, > Hello Diederik, > On Wed Jun 18, 2025 at 12:32 AM CEST, Olivier Benjamin wrote: >> The MIPI panel definition in the PinePhone Pro DTS includes a >> "pinctrl-names" property, which is unused in the absence of pinctrl-0. >> >> Signed-off-by: Olivier Benjamin >> --- >> arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts >> index 5a7341fb6bcb0613af6f3ac31d99355a0f890e89..405140700208365c8631de86a2d7b6e577b7aa7f 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts >> @@ -485,7 +485,6 @@ panel@0 { >> reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>; >> vcc-supply = <&vcc2v8_lcd>; >> iovcc-supply = <&vcc1v8_lcd>; >> - pinctrl-names = "default"; > > Why not define a pinctrl for LCD1_RST for GPIO4_D1 and reference that in > pinctrl-0? (See page 11 and 16 of the schematics) > That is a very fair question. I had simply missed that signal. I'll get right on that, thanks for the suggestion! > Cheers, > Diederik >> >> port { >> mipi_in_panel: endpoint { > -- Olivier Benjamin, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip