From: Jessica Zhang <quic_jesszhan@quicinc.com>
To: Chris Morgan <macroalpha82@gmail.com>,
<linux-rockchip@lists.infradead.org>
Cc: <devicetree@vger.kernel.org>, <conor+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <neil.armstrong@linaro.org>,
<sam@ravnborg.org>, Chris Morgan <macromorgan@hotmail.com>,
<sebastian.reichel@collabora.com>,
<dri-devel@lists.freedesktop.org>, <robh+dt@kernel.org>
Subject: Re: [PATCH V3 2/6] drm/panel: nv3051d: Hold panel in reset for unprepare
Date: Wed, 15 Nov 2023 16:29:05 -0800 [thread overview]
Message-ID: <f9326480-2da5-48da-8528-dc07c9b4f4c8@quicinc.com> (raw)
In-Reply-To: <20231116001742.2340646-3-macroalpha82@gmail.com>
On 11/15/2023 4:17 PM, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Improve the panel's ability to restore from suspend by holding the
> panel in suspend after unprepare.
>
> Fixes: b1d39f0f4264 ("drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel")
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Thanks!
Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
> drivers/gpu/drm/panel/panel-newvision-nv3051d.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c
> index 79de6c886292..c44c6945662f 100644
> --- a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c
> +++ b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c
> @@ -261,6 +261,8 @@ static int panel_nv3051d_unprepare(struct drm_panel *panel)
>
> usleep_range(10000, 15000);
>
> + gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> +
> regulator_disable(ctx->vdd);
>
> return 0;
> --
> 2.34.1
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-11-16 0:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 0:17 [PATCH V3 0/6] rockchip: Add Powkiddy RK2023 Chris Morgan
2023-11-16 0:17 ` [PATCH V3 1/6] dt-bindings: display: panel: Update NewVision NV3051D compatibles Chris Morgan
2023-11-16 20:25 ` Krzysztof Kozlowski
2023-11-16 0:17 ` [PATCH V3 2/6] drm/panel: nv3051d: Hold panel in reset for unprepare Chris Morgan
2023-11-16 0:29 ` Jessica Zhang [this message]
2023-11-16 0:17 ` [PATCH V3 3/6] nv3051d: Add Powkiddy RK2023 Panel Support Chris Morgan
2023-11-16 0:29 ` Jessica Zhang
2023-11-16 0:17 ` [PATCH V3 4/6] dt-bindings: arm: rockchip: Add Powkiddy RK2023 Chris Morgan
2023-11-16 0:17 ` [PATCH V3 5/6] arm64: dts: rockchip: Update powkiddy,rgb30 include to rk2023 DTSI Chris Morgan
2023-11-16 0:17 ` [PATCH V3 6/6] dt-bindings: arm: rockchip: Add Powkiddy RK2023 Chris Morgan
2023-11-16 20:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9326480-2da5-48da-8528-dc07c9b4f4c8@quicinc.com \
--to=quic_jesszhan@quicinc.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox