From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAFFBC02181 for ; Mon, 20 Jan 2025 20:10:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rbdrPCjjfC8kglY9/vm5voR2LUr5V5d41yteGIT0UjQ=; b=Y/wW/cSogDjXy6azMr/RjoeXWn zoYdJQN2ei9xM4AMNttov/ABoBK58eEt2xAELXRF4DElBT7eZAp0TKpL5Ni0VmRQe8fcc/JfnpGng ZKMQow120AOXx7vfRADz43CzHqlbh6k82EOkSPBkX1S44+40nTTpw3712XmY2UvkkJkhECinqRogp YBRl7IM2S31xOdKaKzhcapuuYtkNLL4z90Z39ot/SDX0xl5P84iGkaJUIertiDA8ePNHBQhG42J6R 819IZERrel1Gd+2k0R1gZGSTT3TVQ2JSf0lKxyGZlEqs9yPk3FUhqdWjUM10aO1adoIxOf8b0oFx+ wfxZaFQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tZy6f-00000006NR1-018P; Mon, 20 Jan 2025 20:10:45 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tZy4s-00000006NCJ-01Tv; Mon, 20 Jan 2025 20:08:55 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1737403729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B5LWDDl4PPvpx+DyyaGnR82rDJrKyrO2HYvJ/Dnc9Vg=; b=BEEbpAmBNhrMLzjqxTQacisW+dgpo9N4pv0eow9Q5VAAlkfnChxlYyvcCnhktLK+S6PFHJ MoaZx2s8G3Hj9Hh/A91BTi/XwxnYR4NmhnCB2/bnYSp4am8IOn+B+PUbseK2SLHCiNgQzP dnkyQxGz1qscyExWgImDMEWUui2rpx/VDWJ4JlUJlKh1zUsaQH3EitrJp5dgoXHdKQciCo e/8PO2alpHNuwpt7WEXpfRG5cR1Mx/C4Zj75nGZQ/p/Wtv/X/7VGhmF60+uteBfTTbVjzl /EzofxCcemaJWy0hWKqSjeAyCo4Ezo5Tbc1wERume3U5P0bxioPKz4n9PJN3DA== Date: Mon, 20 Jan 2025 21:08:49 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] arm64: dts: rockchip: Add finer-grained PWM states for the fan on Rock 5C In-Reply-To: <20250120-rock-5c-fan-v1-1-5fb8446c981b@gmail.com> References: <20250120-rock-5c-fan-v1-0-5fb8446c981b@gmail.com> <20250120-rock-5c-fan-v1-1-5fb8446c981b@gmail.com> Message-ID: X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250120_120854_203462_CCE4EA40 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hello Alexey, On 2025-01-20 20:22, Alexey Charkov wrote: > Radxa Heatsink 6540B, which is the official cooling accessory for the > Rock 5C board, includes a small 5V fan, which in my testing spins up > reliably at a PWM setting of 24 (out of 255). It is also quite loud > at the current minimum setting of 64, and noticeably less so at 24. > > Introduce two intermediate PWM states at the lower end of the fan's > operating range to enable better balance between noise and cooling. > > Note further that, in my testing, having the fan run at 44 is enough > to keep the system from thermal throttling with sustained 100% load > on its 8 CPU cores (in 22C ambient temperature and no case) > > Signed-off-by: Alexey Charkov Thanks for the patch, it's looking good to me and the explanations are fine. Please, feel free to include Acked-by: Dragan Simic > --- > arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts > b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts > index > 9b14d5383cdc16947c955b1c6e2a32a50c5df3e6..1b66a69cf0f8795d7305852fa7fef3d0672ada7f > 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts > @@ -71,7 +71,7 @@ led-1 { > fan { > compatible = "pwm-fan"; > #cooling-cells = <2>; > - cooling-levels = <0 64 128 192 255>; > + cooling-levels = <0 24 44 64 128 192 255>; > fan-supply = <&vcc_5v0>; > pwms = <&pwm3 0 10000 0>; > }; _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip