From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacobe Zang <jacobe.zang@wesion.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
asahi@lists.linux.dev
Subject: Re: [PATCH v13 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible
Date: Wed, 28 Aug 2024 15:02:10 +0200 [thread overview]
Message-ID: <faa5f1d0-4300-42b3-a91f-e20fda87dfed@kernel.org> (raw)
In-Reply-To: <20240828-dts-v13-2-6bff9896d649@wesion.com>
On 28/08/2024 10:45, Jacobe Zang wrote:
> Wi-Fi compatible in these DTS is based on PCI ID. Bindings need
> "brcm,bcm4329-fmac" as fallback compatible.
>
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> ---
> arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +-
> arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +-
> arch/arm64/boot/dts/apple/t8112-j493.dts | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
Bindings are being questioned, so link to them in changelog section
would help the maintainers to decide when to apply it.
I am not convinced this is correct bindings change, thus this DTS should
wait.
Your previous patch also misses link to bindings. Whenever you split DTS
to separate series, please always provide link to the bindings, so
people will have the context.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-08-28 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 8:45 [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple Jacobe Zang
2024-08-28 8:45 ` [PATCH v13 1/2] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2 Jacobe Zang
2024-08-28 8:45 ` [PATCH v13 2/2] arm64: dts: apple: add "brcm,bcm4329-fmac" fallback compatible Jacobe Zang
2024-08-28 13:02 ` Krzysztof Kozlowski [this message]
2024-08-28 13:16 ` Jacobe Zang
2024-08-28 8:55 ` [PATCH v13 0/2] Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple Arend van Spriel
2024-08-28 9:09 ` Jacobe Zang
2024-08-28 12:51 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faa5f1d0-4300-42b3-a91f-e20fda87dfed@kernel.org \
--to=krzk@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jacobe.zang@wesion.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marcan@marcan.st \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox