Re: [PATCH 05/12] gpio: pmic-eic-sprd: drop unneeded .set() callback

[Baolin Wang <baolin.wang@linux.alibaba.com>]

On 2025/6/17 20:24, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> The lines on this chip are input-only. GPIO core can handle the missing
> .set() callback so there's no need to implement a dummy here. Drop it.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

> ---
>   drivers/gpio/gpio-pmic-eic-sprd.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
> index d9b228bea42eec53ba9d0d0945125f530a22946c..cb015fb5c9467484022723910354219e2c98d3c7 100644
> --- a/drivers/gpio/gpio-pmic-eic-sprd.c
> +++ b/drivers/gpio/gpio-pmic-eic-sprd.c
> @@ -109,12 +109,6 @@ static int sprd_pmic_eic_direction_input(struct gpio_chip *chip,
>   	return 0;
>   }
>   
> -static void sprd_pmic_eic_set(struct gpio_chip *chip, unsigned int offset,
> -			      int value)
> -{
> -	/* EICs are always input, nothing need to do here. */
> -}
> -
>   static int sprd_pmic_eic_set_debounce(struct gpio_chip *chip,
>   				      unsigned int offset,
>   				      unsigned int debounce)
> @@ -351,7 +345,6 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
>   	pmic_eic->chip.request = sprd_pmic_eic_request;
>   	pmic_eic->chip.free = sprd_pmic_eic_free;
>   	pmic_eic->chip.set_config = sprd_pmic_eic_set_config;
> -	pmic_eic->chip.set = sprd_pmic_eic_set;
>   	pmic_eic->chip.get = sprd_pmic_eic_get;
>   	pmic_eic->chip.can_sleep = true;
>   
> 

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip