Re: [PATCH v5 3/3] arm64: dts: rockchip: Enable HDMI0 audio output for Rock 5B

From: Quentin Schulz <quentin.schulz@cherry.de>
To: Detlev Casanova <detlev.casanova@collabora.com>,
	linux-kernel@vger.kernel.org
Cc: Algea Cao <algea.cao@rock-chips.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Kever Yang <kever.yang@rock-chips.com>,
	dri-devel@lists.freedesktop.org,
	Niklas Cassel <cassel@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	kernel@collabora.com, David Airlie <airlied@gmail.com>,
	Dragan Simic <dsimic@manjaro.org>,
	Simona Vetter <simona@ffwll.ch>, Rob Herring <robh@kernel.org>,
	Robert Foss <rfoss@kernel.org>,
	Sebastian Reichel <sebastian.reichel@collabora.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Sugar Zhang <sugar.zhang@rock-chips.com>,
	linux-rockchip@lists.infradead.org, Chen-Yu Tsai <wens@csie.org>,
	FUKAUMI Naoki <naoki@radxa.com>,
	devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Jonas Karlman <jonas@kwiboo.se>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Johan Jonker <jbx6244@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Jianfeng Liu <liujianfeng1994@gmail.com>,
	Alexey Charkov <alchark@gmail.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH v5 3/3] arm64: dts: rockchip: Enable HDMI0 audio output for Rock 5B
Date: Tue, 4 Feb 2025 11:15:48 +0100	[thread overview]
Message-ID: <fdf9016e-5bde-4800-bdd6-02e159a63592@cherry.de> (raw)
In-Reply-To: <20250203171925.126309-4-detlev.casanova@collabora.com>

Hi Detlev,

On 2/3/25 6:16 PM, Detlev Casanova wrote:
> HDMI audio is available on the Rock 5B HDMI TX port.
> Enable it.
> 
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Will try to remember to send patches for RK3588 Tiger Haikou and RK3588 
Jaguar once those patches get merged :)

Thanks!
Quentin

> ---
>   arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index d597112f1d5b8..88ff5d9db2817 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -204,6 +204,10 @@ &gpu {
>   	status = "okay";
>   };
>   
> +&hdmi0_sound {
> +	status = "okay";
> +};
> +
>   &hdmi0 {
>   	status = "okay";
>   };
> @@ -318,6 +322,10 @@ i2s0_8ch_p0_0: endpoint {
>   	};
>   };
>   
> +&i2s5_8ch {
> +	status = "okay";
> +};
> +
>   &package_thermal {
>   	polling-delay = <1000>;
>   

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip