From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
Dan Murphy <dmurphy@ti.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Kevin Lu <luminlong@139.com>,
linux-rt-devel@lists.linux.dev, devicetree@vger.kernel.org,
Emil-Juhl <emdj@bang-olufsen.dk>
Subject: Re: [PATCH 08/11] ASoC: dt-bindings: clarify areg-supply documentation
Date: Wed, 17 Dec 2025 15:30:39 +0100 [thread overview]
Message-ID: <07f8f657-8d9e-4310-ad9b-99fa6055eb5e@kernel.org> (raw)
In-Reply-To: <20251217-sound-soc-codecs-tvl320adcx140-v1-8-293dea149d7b@pengutronix.de>
On 17/12/2025 14:54, Sascha Hauer wrote:
> From: Emil-Juhl <emdj@bang-olufsen.dk>
>
> The documentation for areg-supply could cause confusion mainly in terms
> of the relationship between AREG and AVDD.
> According to the datasheet[1] the AREG can be one of two cases:
>
> 1) an external 1.8V supply
> 2) generated by an internal regulator (hence a 1.8V output)
>
> [1] https://www.ti.com/lit/ds/symlink/tlv320adc5140.pdf
>
Incomplete DCO chain.
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml b/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> index 0f043a51f1822f4d39214438818e3bc84d3e8681..0c550c04f5ef239f403bea668ffd8c6051d86821 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> @@ -41,8 +41,8 @@ properties:
>
> areg-supply:
> description: |
> - Regulator with AVDD at 3.3V. If not defined then the internal regulator
> - is enabled.
> + External supply of 1.8V. If not defined then the internal regulator is
> + enabled instead.
Please re-order the patches. Fixes are always before new features and
you would solve yourself one review question...
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-17 14:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 13:54 [PATCH 00/11] sound: codecs: tlv320adcx140: assorted patches Sascha Hauer
2025-12-17 13:54 ` [PATCH 01/11] ASoC: tlv320adcx140: invert DRE_ENABLE Sascha Hauer
2025-12-17 13:54 ` [PATCH 02/11] ASoC: tlv320adcx140: fix null pointer Sascha Hauer
2025-12-17 13:58 ` Mark Brown
2025-12-17 13:54 ` [PATCH 03/11] ASoC: tlv320adcx140: Propagate error codes during probe Sascha Hauer
2025-12-17 13:54 ` [PATCH 04/11] ASoC: tlv320adcx140: fix word length Sascha Hauer
2025-12-17 13:54 ` [PATCH 05/11] ASoC: tlv320adcx140: implement register caching Sascha Hauer
2025-12-17 14:11 ` Mark Brown
2025-12-17 13:54 ` [PATCH 06/11] ASoC: tlv320adcx140: add avdd and iovdd supply Sascha Hauer
2025-12-17 13:54 ` [PATCH 07/11] ASoC: dt-bindings: " Sascha Hauer
2025-12-17 14:29 ` Krzysztof Kozlowski
2025-12-17 13:54 ` [PATCH 08/11] ASoC: dt-bindings: clarify areg-supply documentation Sascha Hauer
2025-12-17 14:30 ` Krzysztof Kozlowski [this message]
2025-12-18 14:13 ` Sascha Hauer
2025-12-17 13:54 ` [PATCH 09/11] ASoC: tlv320adcx140: Add kcontrols for TDM Slot assignment Sascha Hauer
2025-12-17 14:13 ` Mark Brown
2025-12-17 13:55 ` [PATCH 10/11] ASoC: tlv320adcx140: add kcontrol for num biquads Sascha Hauer
2025-12-17 13:55 ` [PATCH 11/11] ASoC: tlv320adcx140: add channel sum control Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07f8f657-8d9e-4310-ad9b-99fa6055eb5e@kernel.org \
--to=krzk@kernel.org \
--cc=afd@ti.com \
--cc=baojun.xu@ti.com \
--cc=bigeasy@linutronix.de \
--cc=broonie@kernel.org \
--cc=clrkwllms@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=emdj@bang-olufsen.dk \
--cc=kevin-lu@ti.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=linux-sound@vger.kernel.org \
--cc=luminlong@139.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=s.hauer@pengutronix.de \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox