From: Gatien Chevallier <gatien.chevallier@foss.st.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Paul Cercueil <paul@crapouillou.net>
Cc: <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-rt-devel@lists.linux.dev>,
Gatien Chevallier <gatien.chevallier@foss.st.com>,
<fabrice.gasnier@foss.st.com>
Subject: [PATCH v2 2/2] Input: gpio-keys - fix possible concurrent access in gpio_keys_irq_timer()
Date: Wed, 28 May 2025 10:50:22 +0200 [thread overview]
Message-ID: <20250528-gpio_keys_preempt_rt-v2-2-3fc55a9c3619@foss.st.com> (raw)
In-Reply-To: <20250528-gpio_keys_preempt_rt-v2-0-3fc55a9c3619@foss.st.com>
gpio_keys_irq_isr() and gpio_keys_irq_timer() access the same resources.
There could be a concurrent access if a GPIO interrupt occurs in parallel
of a HR timer interrupt.
Guard back those resources with a spinlock.
Fixes: 019002f20cb5 ("Input: gpio-keys - use hrtimer for release timer")
Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
---
drivers/input/keyboard/gpio_keys.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index d884538107c9654d21e37fa20e0b3b6cd9a25ee4..f9db86da0818b24d3b6611b4d4e23c96846dbf18 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -449,6 +449,8 @@ static enum hrtimer_restart gpio_keys_irq_timer(struct hrtimer *t)
release_timer);
struct input_dev *input = bdata->input;
+ guard(spinlock_irqsave)(&bdata->lock);
+
if (bdata->key_pressed) {
input_report_key(input, *bdata->code, 0);
input_sync(input);
--
2.25.1
next prev parent reply other threads:[~2025-05-28 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 8:50 [PATCH v2 0/2] Input: gpio-keys - Fixes for interrupt callbacks Gatien Chevallier
2025-05-28 8:50 ` [PATCH v2 1/2] Input: gpio-keys - fix a sleep while atomic with PREEMPT_RT Gatien Chevallier
2025-05-28 8:50 ` Gatien Chevallier [this message]
2025-05-30 23:12 ` [PATCH v2 0/2] Input: gpio-keys - Fixes for interrupt callbacks Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250528-gpio_keys_preempt_rt-v2-2-3fc55a9c3619@foss.st.com \
--to=gatien.chevallier@foss.st.com \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=paul@crapouillou.net \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).