* [PATCH] accel/ivpu: Remove lockdep_assert_irqs_disabled()
@ 2025-07-15 16:59 Maarten Lankhorst
2025-07-22 7:53 ` Jacek Lawrynowicz
0 siblings, 1 reply; 3+ messages in thread
From: Maarten Lankhorst @ 2025-07-15 16:59 UTC (permalink / raw)
To: Jacek Lawrynowicz, Maciej Falkowski, Oded Gabbay,
Sebastian Andrzej Siewior, Clark Williams, Steven Rostedt
Cc: dri-devel, linux-kernel, linux-rt-devel, Maarten Lankhorst
This breaks on PREEMPT_RT, and should be unneeded since
lockdep can track irq disabled status itself.
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
drivers/accel/ivpu/ivpu_ipc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/accel/ivpu/ivpu_ipc.c b/drivers/accel/ivpu/ivpu_ipc.c
index 39f83225c1815..5f00809d448af 100644
--- a/drivers/accel/ivpu/ivpu_ipc.c
+++ b/drivers/accel/ivpu/ivpu_ipc.c
@@ -141,7 +141,6 @@ ivpu_ipc_rx_msg_add(struct ivpu_device *vdev, struct ivpu_ipc_consumer *cons,
struct ivpu_ipc_rx_msg *rx_msg;
lockdep_assert_held(&ipc->cons_lock);
- lockdep_assert_irqs_disabled();
rx_msg = kzalloc(sizeof(*rx_msg), GFP_ATOMIC);
if (!rx_msg) {
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] accel/ivpu: Remove lockdep_assert_irqs_disabled()
2025-07-15 16:59 [PATCH] accel/ivpu: Remove lockdep_assert_irqs_disabled() Maarten Lankhorst
@ 2025-07-22 7:53 ` Jacek Lawrynowicz
2025-07-22 8:28 ` Maarten Lankhorst
0 siblings, 1 reply; 3+ messages in thread
From: Jacek Lawrynowicz @ 2025-07-22 7:53 UTC (permalink / raw)
To: Maarten Lankhorst, Maciej Falkowski, Oded Gabbay,
Sebastian Andrzej Siewior, Clark Williams, Steven Rostedt
Cc: dri-devel, linux-kernel, linux-rt-devel
Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
On 7/15/2025 6:59 PM, Maarten Lankhorst wrote:
> This breaks on PREEMPT_RT, and should be unneeded since
> lockdep can track irq disabled status itself.
>
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> ---
> drivers/accel/ivpu/ivpu_ipc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_ipc.c b/drivers/accel/ivpu/ivpu_ipc.c
> index 39f83225c1815..5f00809d448af 100644
> --- a/drivers/accel/ivpu/ivpu_ipc.c
> +++ b/drivers/accel/ivpu/ivpu_ipc.c
> @@ -141,7 +141,6 @@ ivpu_ipc_rx_msg_add(struct ivpu_device *vdev, struct ivpu_ipc_consumer *cons,
> struct ivpu_ipc_rx_msg *rx_msg;
>
> lockdep_assert_held(&ipc->cons_lock);
> - lockdep_assert_irqs_disabled();
>
> rx_msg = kzalloc(sizeof(*rx_msg), GFP_ATOMIC);
> if (!rx_msg) {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] accel/ivpu: Remove lockdep_assert_irqs_disabled()
2025-07-22 7:53 ` Jacek Lawrynowicz
@ 2025-07-22 8:28 ` Maarten Lankhorst
0 siblings, 0 replies; 3+ messages in thread
From: Maarten Lankhorst @ 2025-07-22 8:28 UTC (permalink / raw)
To: Jacek Lawrynowicz, Maciej Falkowski, Oded Gabbay,
Sebastian Andrzej Siewior, Clark Williams, Steven Rostedt
Cc: dri-devel, linux-kernel, linux-rt-devel
Hey,
Den 2025-07-22 kl. 09:53, skrev Jacek Lawrynowicz:
> Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Thanks, pushed to misc-next.
Best regards,
~Maarten
> On 7/15/2025 6:59 PM, Maarten Lankhorst wrote:
>> This breaks on PREEMPT_RT, and should be unneeded since
>> lockdep can track irq disabled status itself.
>>
>> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
>> ---
>> drivers/accel/ivpu/ivpu_ipc.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/accel/ivpu/ivpu_ipc.c b/drivers/accel/ivpu/ivpu_ipc.c
>> index 39f83225c1815..5f00809d448af 100644
>> --- a/drivers/accel/ivpu/ivpu_ipc.c
>> +++ b/drivers/accel/ivpu/ivpu_ipc.c
>> @@ -141,7 +141,6 @@ ivpu_ipc_rx_msg_add(struct ivpu_device *vdev, struct ivpu_ipc_consumer *cons,
>> struct ivpu_ipc_rx_msg *rx_msg;
>>
>> lockdep_assert_held(&ipc->cons_lock);
>> - lockdep_assert_irqs_disabled();
>>
>> rx_msg = kzalloc(sizeof(*rx_msg), GFP_ATOMIC);
>> if (!rx_msg) {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-22 8:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-15 16:59 [PATCH] accel/ivpu: Remove lockdep_assert_irqs_disabled() Maarten Lankhorst
2025-07-22 7:53 ` Jacek Lawrynowicz
2025-07-22 8:28 ` Maarten Lankhorst
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).