linux-rt-devel.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-rt-devel@lists.linux.dev,
	Russell King <linux@armlinux.org.uk>,
	Xie Yuanbin <xieyuanbin1@huawei.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 4/5] ARM: Disable jump-label on PREEMPT_RT.
Date: Thu, 30 Oct 2025 16:28:00 +0100	[thread overview]
Message-ID: <20251030152800.9LD5D2GP@linutronix.de> (raw)
In-Reply-To: <a86e9827-9b8b-4313-8d46-5fb2af5b8826@app.fastmail.com>

On 2025-10-30 16:24:16 [+0100], Arnd Bergmann wrote:
> On Wed, Oct 29, 2025, at 16:59, Sebastian Andrzej Siewior wrote:
> > From: Thomas Gleixner <tglx@linutronix.de>
> >
> > jump-labels are used to efficiently switch between two possible code
> > paths. To achieve this, stop_machine() is used to keep the CPU in a
> > known state while the opcode is modified. The usage of stop_machine()
> > here leads to large latency spikes which can be observed on PREEMPT_RT.
> >
> > Jump labels may change the target during runtime and are not restricted
> > to debug or "configuration/ setup" part of a PREEMPT_RT system where
> > high latencies could be defined as acceptable.
> >
> > Disable jump-label support on a PREEMPT_RT system.
> >
> > [bigeasy: Patch description.]
> >
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> >  arch/arm/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 864a14a434b08..99c9b1c320af8 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -80,7 +80,7 @@ config ARM
> >  	select HAS_IOPORT
> >  	select HAVE_ARCH_AUDITSYSCALL if AEABI && !OABI_COMPAT
> >  	select HAVE_ARCH_BITREVERSE if (CPU_32v7M || CPU_32v7) && !CPU_32v6
> > -	select HAVE_ARCH_JUMP_LABEL if !XIP_KERNEL && !CPU_ENDIAN_BE32 && MMU
> > +	select HAVE_ARCH_JUMP_LABEL if !XIP_KERNEL && !CPU_ENDIAN_BE32 && MMU 
> > && !PREEMPT_RT
> 
> I posted a slightly different version last year, which optimizes
> the uniprocessor version and has a little more information
> in the changelog:
> 
> https://lore.kernel.org/all/20241210160556.2341497-2-arnd@kernel.org/

This actually slipped my mind but I was fine with it according the link.
So let me replace this, too.

>      Arnd

Sebastian

  reply	other threads:[~2025-10-30 15:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 15:59 [PATCH 0/5] ARM: Remaining PREEMPT_RT bits Sebastian Andrzej Siewior
2025-10-29 15:59 ` [PATCH 1/5] ARM: mm: fault: Move harden_branch_predictor() before interrupts are enabled Sebastian Andrzej Siewior
2025-10-29 15:59 ` [PATCH 2/5] ARM: mm: fault: Enable interrupts before invoking __do_user_fault() Sebastian Andrzej Siewior
2025-10-29 15:59 ` [PATCH 3/5] ARM: Disable FAST_GUP on PREEMPT_RT if HIGHPTE is also enabled Sebastian Andrzej Siewior
2025-10-30 15:15   ` Arnd Bergmann
2025-10-30 15:24     ` Sebastian Andrzej Siewior
2025-10-29 15:59 ` [PATCH 4/5] ARM: Disable jump-label on PREEMPT_RT Sebastian Andrzej Siewior
2025-10-30  2:39   ` Xie Yuanbin
2025-10-30  7:23     ` Sebastian Andrzej Siewior
2025-10-30  7:45       ` Xie Yuanbin
2025-10-30  7:55         ` Sebastian Andrzej Siewior
2025-10-30  9:46           ` Steven Rostedt
2025-10-30  9:56             ` Sebastian Andrzej Siewior
2025-10-30 10:05               ` Steven Rostedt
2025-10-30 10:38           ` Russell King (Oracle)
2025-10-30 11:10             ` Sebastian Andrzej Siewior
2025-10-30 15:24   ` Arnd Bergmann
2025-10-30 15:28     ` Sebastian Andrzej Siewior [this message]
2025-10-29 15:59 ` [PATCH 5/5] ARM: Allow to enable RT Sebastian Andrzej Siewior
2025-10-30 15:18   ` Arnd Bergmann
2025-10-30 15:22     ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251030152800.9LD5D2GP@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=linux@armlinux.org.uk \
    --cc=tglx@linutronix.de \
    --cc=xieyuanbin1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).