[PATCH] debugobjects: Allow to refill the pool before SYSTEM_SCHEDULING

[PATCH] debugobjects: Allow to refill the pool before SYSTEM_SCHEDULING

[Sebastian Andrzej Siewior]

The pool of free objects is refilled on several occasions such as object
initialisation. On PREEMPT_RT refilling is limited to preemptible
sections due to sleeping locks used by the memory allocator. The system
boots with disabled interrupts so the pool can not be refilled.

If too many objects are initialized and the pool gets empty then
debugobjects disables itself.

Refiling can also happen early in the boot with disabled interrupts as
long as the scheduler is not operational. If the scheduler can not
preempt a task then a sleeping lock can not be contended.

Allow to additionally refill the pool if the scheduler is not
operational.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 lib/debugobjects.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 7f50c4480a4e3..7017e5c8f32dd 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -714,7 +714,7 @@ static void debug_objects_fill_pool(void)
 	 * raw_spinlock_t are basically the same type and this lock-type
 	 * inversion works just fine.
 	 */
-	if (!IS_ENABLED(CONFIG_PREEMPT_RT) || preemptible()) {
+	if (!IS_ENABLED(CONFIG_PREEMPT_RT) || preemptible() || system_state < SYSTEM_SCHEDULING) {
 		/*
 		 * Annotate away the spinlock_t inside raw_spinlock_t warning
 		 * by temporarily raising the wait-type to WAIT_SLEEP, matching
-- 
2.51.0

Re: [PATCH] debugobjects: Allow to refill the pool before SYSTEM_SCHEDULING

[Sebastian Andrzej Siewior]

On 2025-11-06 13:06:28 [+0100], To linux-kernel@vger.kernel.org wrote:
> The pool of free objects is refilled on several occasions such as object
> initialisation. On PREEMPT_RT refilling is limited to preemptible
> sections due to sleeping locks used by the memory allocator. The system
> boots with disabled interrupts so the pool can not be refilled.
> 
> If too many objects are initialized and the pool gets empty then
> debugobjects disables itself.
> 
> Refiling can also happen early in the boot with disabled interrupts as
> long as the scheduler is not operational. If the scheduler can not
> preempt a task then a sleeping lock can not be contended.
> 
> Allow to additionally refill the pool if the scheduler is not
> operational.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

A gentle ping.

Sebastian