Re: [PATCH 18/21] iio: Replace IRQF_ONESHOT with IRQF_NO_THREAD

Sebastian Andrzej Siewior
2026-01-26T10:10:37Z

On 2026-01-26 11:51:13 [+0200], Andy Shevchenko wrote:
> > > > Cc: Lars-Peter Clausen <lars@metafoo.de>
> > > > Cc: Michael Hennerich <Michael.Hennerich@analog.com>
> > > > Cc: Puranjay Mohan <puranjay@kernel.org>
> > > > Cc: Jonathan Cameron <jic23@kernel.org>
> > > > Cc: David Lechner <dlechner@baylibre.com>
> > > > Cc: "Nuno Sá" <nuno.sa@analog.com>
> > > > Cc: Andy Shevchenko <andy@kernel.org>
> > > > Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>
> > > > Cc: Marcus Folkesson <marcus.folkesson@gmail.com>
> > > > Cc: Kent Gustavsson <kent@minoris.se>
> > > > Cc: Gustavo Silva <gustavograzs@gmail.com>
> > > > Cc: Nishant Malpani <nish.malpani25@gmail.com>
> > > > Cc: linux-iio@vger.kernel.org
> > >
…
> I didn't follow. How? What tools do you use?

b4/ git.

> > So I have to move them for each submission. Or is there something I am not
> > aware of?
>
> Make them in the tail of commit messages locally with a delimiter, they will
> always be present as long as they are in your tree.
>
> I dunno if `b4` manages the Cc lists separately. At least I see no-one using
> `b4` *and* putting the Cc noise into the commit messages, so I assume it
> behaves nicely.

I point is if I move them for one submission, I lose it on the next if I
update patches in tree and re-export them.

> > > > + ret = devm_request_irq(dev, st->irq,
> > > > + iio_trigger_generic_data_rdy_poll,
> > > > + IRQF_TRIGGER_RISING | IRQF_NO_THREAD,
> > > > + indio_dev->name, st->dready_trig);
> > > > if (ret < 0)
> > > > return ret;
> > >
> > > Interestingly that this driver ignores the flags from firmware... Seems to me
> > > like a bug (not in your patch, obviously). Ditto for other drivers doing similar
> > > things.
> >
> > If the irq-chip is level or unknown mode on boot up/ default and the
> > device can only operate as an edge-rising then I don't see why this
> > should be a bug.
>
> But if FW says use "level", wouldn't this setting override it?

Yes, it will. It was common to use it pre-device-tree time where this
information was not configured automatically before ->probe. Now it
might be missing/wrong in the dt for some of the old devices.
It might be a left-over which continued to grow and spread.

Sebastian