public inbox for linux-rt-devel@lists.linux.dev
 help / color / mirror / Atom feed
From: Maarten Lankhorst <dev@lankhorst.se>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: linux-rt-devel@lists.linux.dev, dri-devel@lists.freedesktop.org,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Tvrtko Ursulin <tvrtko.ursulin@igalia.com>,
	Maarten Lankhorst <dev@lankhorst.se>
Subject: [i915-rt v6 17/24] drm/i915: Drop the irqs_disabled() check
Date: Fri, 20 Feb 2026 09:37:15 +0100	[thread overview]
Message-ID: <20260220083657.28815-43-dev@lankhorst.se> (raw)
In-Reply-To: <20260220083657.28815-26-dev@lankhorst.se>

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

The !irqs_disabled() check triggers on PREEMPT_RT even with
i915_sched_engine::lock acquired. The reason is the lock is transformed
into a sleeping lock on PREEMPT_RT and does not disable interrupts.

There is no need to check for disabled interrupts. The lockdep
annotation below already check if the lock has been acquired by the
caller and will yell if the interrupts are not disabled.

Remove the !irqs_disabled() check.

Reported-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
---
 drivers/gpu/drm/i915/i915_request.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index d2c7b1090df08..f66f8efc70629 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -610,7 +610,6 @@ bool __i915_request_submit(struct i915_request *request)
 
 	RQ_TRACE(request, "\n");
 
-	GEM_BUG_ON(!irqs_disabled());
 	lockdep_assert_held(&engine->sched_engine->lock);
 
 	/*
@@ -719,7 +718,6 @@ void __i915_request_unsubmit(struct i915_request *request)
 	 */
 	RQ_TRACE(request, "\n");
 
-	GEM_BUG_ON(!irqs_disabled());
 	lockdep_assert_held(&engine->sched_engine->lock);
 
 	/*
-- 
2.51.0


  parent reply	other threads:[~2026-02-20  8:37 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-20  8:36 [i915-rt v6 00/24] drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe Maarten Lankhorst
2026-02-20  8:36 ` [i915-rt v6 01/24] drm/vblank_work: Add methods to schedule vblank_work in 2 stages Maarten Lankhorst
2026-02-20 12:24   ` [i915-rt v6.1 1/1] " Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 02/24] drm/vblank: Add a 2-stage version of drm_crtc_arm_vblank_event Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 03/24] drm/intel/display: Make intel_crtc_arm_vblank_event static Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 04/24] drm/intel/display: Convert vblank event handling to 2-stage arming Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 05/24] drm/i915/display: Move vblank put until after critical section Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 06/24] drm/i915/display: Remove locking from intel_vblank_evade " Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 07/24] drm/i915/display: Handle vlv dsi workaround in scanline_in_safe_range too Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 08/24] drm/i915: Use preempt_disable/enable_rt() where recommended Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 09/24] drm/i915/display: Make get_vblank_counter use intel_de_read_fw() Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 10/24] drm/i915/display: Do not take uncore lock in i915_get_vblank_counter Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 11/24] drm/i915/display: Make icl_dsi_frame_update use _fw too Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 12/24] drm/i915/display: Use intel_de_read/write_fw in colorops Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 13/24] drm/i915/display: Use intel_de_write_fw in intel_pipe_fastset Maarten Lankhorst
2026-02-25  9:25   ` Jani Nikula
2026-02-25 11:59     ` Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 14/24] drm/i915/display: Make set_pipeconf use the fw variants Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 15/24] drm/i915/display: Fix intel_lpe_audio_irq_handler for PREEMPT-RT Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 16/24] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Maarten Lankhorst
2026-02-20  8:37 ` Maarten Lankhorst [this message]
2026-02-20  8:37 ` [i915-rt v6 18/24] drm/i915/guc: Consider also RCU depth in busy loop Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 19/24] drm/i915/gt: Fix selftests on PREEMPT_RT Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 20/24] drm/i915/gt: Set stop_timeout() correctly on PREEMPT-RT Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 21/24] drm/i915/display: Remove uncore lock from vlv_atomic_update_fifo Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 22/24] Revert "drm/i915: Depend on !PREEMPT_RT." Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 23/24] PREEMPT_RT injection Maarten Lankhorst
2026-02-20  8:37 ` [i915-rt v6 24/24] FOR-CI: bump MAX_STACK_TRACE_ENTRIES Maarten Lankhorst
2026-02-24 14:15   ` Sebastian Andrzej Siewior
2026-02-25 12:32     ` Maarten Lankhorst
2026-02-24 16:27 ` [i915-rt v6 00/24] drm/i915/display: All patches to make PREEMPT_RT work on i915 + xe Sebastian Andrzej Siewior
2026-02-24 16:59   ` Sebastian Andrzej Siewior
2026-02-25  7:58     ` Sebastian Andrzej Siewior
2026-02-25 12:15       ` Maarten Lankhorst
2026-02-25 20:06       ` Maarten Lankhorst
2026-02-26 12:07         ` Sebastian Andrzej Siewior
2026-02-26 14:19           ` Sebastian Andrzej Siewior
2026-02-26 14:38             ` Sebastian Andrzej Siewior
2026-03-05 10:19               ` Maarten Lankhorst
2026-03-05 10:42               ` Maarten Lankhorst
2026-03-05 10:50                 ` Sebastian Andrzej Siewior
2026-03-05 11:11                   ` Maarten Lankhorst
2026-03-05 11:19                     ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260220083657.28815-43-dev@lankhorst.se \
    --to=dev@lankhorst.se \
    --cc=bigeasy@linutronix.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=tvrtko.ursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox