From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiayuan Chen <jiayuan.chen@linux.dev>,
linux-rt-devel@lists.linux.dev,
Clark Williams <clrkwllms@kernel.org>,
linux-kernel@vger.kernel.org,
"Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH v1] irq_work: Fix use-after-free in irq_work_single on PREEMPT_RT
Date: Wed, 25 Mar 2026 16:55:04 +0100 [thread overview]
Message-ID: <20260325155504.tm4zHWMI@linutronix.de> (raw)
In-Reply-To: <20260325115315.052e34ac@gandalf.local.home>
On 2026-03-25 11:53:15 [-0400], Steven Rostedt wrote:
> On Wed, 25 Mar 2026 16:38:26 +0100
> Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
>
> > Most irq-work aren't free()ed since they are static and remain around.
> > There is no task assigned if there is no active waiter.
> > Wouldn't it be easier to kfree_rcu() the struct using the irq-work?
>
> I guess we should add some kind of helper then. Like tracepoints have.
>
> tracepoint_synchronize_unregister()
>
> Perhaps have a:
>
> irq_work_synchronize_free();
>
> Or something like that to let developers know that they just can't safely free a
> structure that contains an irq_work?
That sounds great.
> -- Steve
Sebastian
next prev parent reply other threads:[~2026-03-25 15:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 3:05 [PATCH v1] irq_work: Fix use-after-free in irq_work_single on PREEMPT_RT Jiayuan Chen
2026-03-25 15:13 ` Steven Rostedt
2026-03-25 15:38 ` Sebastian Andrzej Siewior
2026-03-25 15:53 ` Steven Rostedt
2026-03-25 15:55 ` Sebastian Andrzej Siewior [this message]
2026-03-25 16:34 ` Jiayuan Chen
2026-03-25 17:05 ` Sebastian Andrzej Siewior
2026-03-25 17:44 ` Steven Rostedt
2026-03-25 17:51 ` Sebastian Andrzej Siewior
2026-03-25 17:55 ` Steven Rostedt
2026-03-25 17:59 ` Sebastian Andrzej Siewior
2026-03-26 2:27 ` Jiayuan Chen
2026-03-26 8:11 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325155504.tm4zHWMI@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox