From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ilia Lin <ilialin@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH 3/3] regulator: qcom_spmi: don't take a sleeping lock in the SAW IPI
Date: Tue, 20 Oct 2026 09:42:01 +0200 [thread overview]
Message-ID: <20261020074201.Hug86drL@linutronix.de> (raw)
In-Reply-To: <20261019-fix-qcom-saw-v1-3-9c7ba3fc2493@oss.qualcomm.com>
On 2026-10-19 17:39:21 [+0300], Dmitry Baryshkov wrote:
> --- a/drivers/regulator/qcom_spmi-regulator.c
> +++ b/drivers/regulator/qcom_spmi-regulator.c
> @@ -2523,12 +2532,22 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev)
> if (!reg)
> return -ENODEV;
>
> - syscon = of_parse_phandle(node, "qcom,saw-reg", 0);
> - if (syscon) {
> - saw_regmap = syscon_node_to_regmap(syscon);
> - of_node_put(syscon);
> - if (IS_ERR(saw_regmap))
> - dev_err(dev, "ERROR reading SAW regmap\n");
> + saw = of_parse_phandle(node, "qcom,saw-reg", 0);
> + if (saw) {
> + saw_base = devm_of_iomap(dev, saw, 0, NULL);
I was asking if the syscon could be made using a raw_spinlock_t if all
users do simple reads/writes.
https://lore.kernel.org/all/20260929-rbrue-suez-upstreaming-mtk-pinctrl-raw-regmap-v1-1-db92943f42cb@gmail.com/T/#u
If the qcom,saw-reg registers are not shared anywhere, then this should
work, too.
> + of_node_put(saw);
Sebastian
next prev parent reply other threads:[~2026-10-20 7:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 14:39 [PATCH 0/3] soc: qcom: several fixes for SAW handling Dmitry Baryshkov
2026-10-19 14:39 ` [PATCH 1/3] soc: qcom: spm: fix the SDM660 silver L2 AVS control value Dmitry Baryshkov
2026-10-20 5:52 ` Konrad Dybcio
2026-10-19 14:39 ` [PATCH 2/3] soc: qcom: spm: don't clobber the SAW control registers Dmitry Baryshkov
2026-10-20 6:03 ` Konrad Dybcio
2026-10-19 14:39 ` [PATCH 3/3] regulator: qcom_spmi: don't take a sleeping lock in the SAW IPI Dmitry Baryshkov
2026-10-20 6:08 ` Konrad Dybcio
2026-10-20 7:42 ` Sebastian Andrzej Siewior [this message]
2026-10-19 16:24 ` [PATCH 0/3] soc: qcom: several fixes for SAW handling Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261020074201.Hug86drL@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=broonie@kernel.org \
--cc=clrkwllms@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=ilialin@codeaurora.org \
--cc=konradybcio@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox