Linux real-time development
 help / color / mirror / Atom feed
From: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: <hansg@kernel.org>,
	"Kurmi, Suresh Kumar" <suresh.kumar.kurmi@intel.com>,
	"Saarinen, Jani" <jani.saarinen@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>, <linux-rt-devel@lists.linux.dev>,
	<sfr@canb.auug.org.au>, <ilpo.jarvinen@linux.intel.com>,
	<regressions@leemhuis.info>
Subject: Re: REGRESSION on linux-next (next-20260115)
Date: Wed, 21 Jan 2026 17:43:50 +0530	[thread overview]
Message-ID: <5d83c0d0-8f82-40a8-bca6-7052658a5fb6@intel.com> (raw)
In-Reply-To: <20260121090154.Lpaj9hrr@linutronix.de>



On 1/21/2026 2:31 PM, Sebastian Andrzej Siewior wrote:
> On 2026-01-21 13:59:38 [+0530], Borah, Chaitanya Kumar wrote:
>>
>> Looks like it.
>>    9:          1          0  IO-APIC   9-fasteoi   acpi, INT0002
> 
> Does the following help?
> 
> diff --git a/drivers/platform/x86/intel/int0002_vgpio.c b/drivers/platform/x86/intel/int0002_vgpio.c
> index 6f5629dc3f8db..562e880256436 100644
> --- a/drivers/platform/x86/intel/int0002_vgpio.c
> +++ b/drivers/platform/x86/intel/int0002_vgpio.c
> @@ -206,8 +206,8 @@ static int int0002_probe(struct platform_device *pdev)
>   	 * FIXME: augment this if we managed to pull handling of shared
>   	 * IRQs into gpiolib.
>   	 */
> -	ret = devm_request_irq(dev, irq, int0002_irq,
> -			       IRQF_ONESHOT | IRQF_SHARED, "INT0002", chip);
> +	ret = devm_request_irq(dev, irq, int0002_irq, IRQF_SHARED, "INT0002",
> +			       chip);
>   	if (ret) {
>   		dev_err(dev, "Error requesting IRQ %d: %d\n", irq, ret);
>   		return ret;
> diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> index 266f2b39213a0..b2bb878abd113 100644
> --- a/include/linux/interrupt.h
> +++ b/include/linux/interrupt.h
> @@ -228,7 +228,7 @@ static inline int __must_check
>   devm_request_irq(struct device *dev, unsigned int irq, irq_handler_t handler,
>   		 unsigned long irqflags, const char *devname, void *dev_id)
>   {
> -	return devm_request_threaded_irq(dev, irq, handler, NULL, irqflags,
> +	return devm_request_threaded_irq(dev, irq, handler, NULL, irqflags | IRQF_COND_ONESHOT,
>   					 devname, dev_id);
>   }
>   
> My guess would be that the int0002_vgpio.c results in a warning without
> requesting the interrupt while the interrupt.h change should fix it and
> the warning should be gone.
> 

This helps. Thank you for the patch. Would you be floating it soon?

==
Chaitanya



  parent reply	other threads:[~2026-01-21 12:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21  7:12 REGRESSION on linux-next (next-20260115) Borah, Chaitanya Kumar
2026-01-21  7:53 ` Sebastian Andrzej Siewior
2026-01-21  8:29   ` Borah, Chaitanya Kumar
2026-01-21  9:01     ` Sebastian Andrzej Siewior
2026-01-21 10:20       ` Hans de Goede
2026-01-21 10:39         ` Sebastian Andrzej Siewior
2026-01-21 11:13           ` Hans de Goede
2026-01-21 12:13       ` Borah, Chaitanya Kumar [this message]
2026-01-21 13:19         ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d83c0d0-8f82-40a8-bca6-7052658a5fb6@intel.com \
    --to=chaitanya.kumar.borah@intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.saarinen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=regressions@leemhuis.info \
    --cc=sfr@canb.auug.org.au \
    --cc=suresh.kumar.kurmi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox