From: Florian Westphal <fw@strlen.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-rt-devel@lists.linux.dev,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4] netfilter: Exclude LEGACY TABLES on PREEMPT_RT.
Date: Mon, 30 Jun 2025 16:45:57 +0200 [thread overview]
Message-ID: <aGKjJaZBOjpuB6Rw@strlen.de> (raw)
In-Reply-To: <20250630143639.jPnUbTvr@linutronix.de>
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> diff --git a/tools/testing/selftests/net/netfilter/config b/tools/testing/selftests/net/netfilter/config
> index c981d2a38ed68..79d5b33966ba1 100644
> --- a/tools/testing/selftests/net/netfilter/config
> +++ b/tools/testing/selftests/net/netfilter/config
> @@ -97,4 +97,4 @@ CONFIG_XFRM_STATISTICS=y
> CONFIG_NET_PKTGEN=m
> CONFIG_TUN=m
> CONFIG_INET_DIAG=m
> -CONFIG_SCTP_DIAG=m
> +CONFIG_INET_SCTP_DIAG=m
> diff --git a/tools/testing/selftests/tc-testing/config b/tools/testing/selftests/tc-testing/config
> index db176fe7d0c3f..8e902f7f1a181 100644
> --- a/tools/testing/selftests/tc-testing/config
> +++ b/tools/testing/selftests/tc-testing/config
> @@ -21,6 +21,7 @@ CONFIG_NF_NAT=m
> CONFIG_NETFILTER_XT_TARGET_LOG=m
>
> CONFIG_NET_SCHED=y
> +CONFIG_IP_SET=m
>
> #
> # Queueing/Scheduling
>
> The CONFIG_SCTP_DIAG switch probably never existed.
> tc-testing asks for NET_EMATCH_IPSET but this one always required
> IP_SET. We can either remove them or fix them as suggested.
> Preferences?
Fix them as suggested.
> > I suspect that it would make sense to split the config tweaks into
> > a distinct patch, however.
>
> I can split the config tweaks out of it if you want.
That would be my preference, will also help to root-cause in case
something breaks.
> If we are not making the legacy bits default, because we want to get rid
> of them eventually, and therefore we fix the configs for the testsuite:
> What about those under arch/*/configs?
I don't see many changes to those, so looks like they can be left alone.
prev parent reply other threads:[~2025-06-30 14:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 15:28 [PATCH v4] netfilter: Exclude LEGACY TABLES on PREEMPT_RT Sebastian Andrzej Siewior
2025-04-15 15:14 ` Pablo Neira Ayuso
2025-06-13 12:50 ` Sebastian Andrzej Siewior
2025-06-13 15:30 ` Florian Westphal
2025-06-27 10:58 ` Sebastian Andrzej Siewior
2025-06-27 14:17 ` Florian Westphal
2025-06-30 14:36 ` Sebastian Andrzej Siewior
2025-06-30 14:45 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGKjJaZBOjpuB6Rw@strlen.de \
--to=fw@strlen.de \
--cc=bigeasy@linutronix.de \
--cc=coreteam@netfilter.org \
--cc=kadlec@netfilter.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).