From: Lukas Wunner <lukas@wunner.de>
To: Crystal Wood <crwood@redhat.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Attila Fazekas <afazekas@redhat.com>,
linux-pci@vger.kernel.org, linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH] PCI/AER: Use IRQF_NO_THREAD on aer_irq
Date: Wed, 3 Sep 2025 10:10:10 +0200 [thread overview]
Message-ID: <aLf34pnRmk4ip7KS@wunner.de> (raw)
In-Reply-To: <20250902224441.368483-1-crwood@redhat.com>
On Tue, Sep 02, 2025 at 05:44:41PM -0500, Crystal Wood wrote:
> On PREEMPT_RT, currently both aer_irq and aer_isr run in separate threads,
My understanding is that if request_threaded_irq() is passed both a
non-NULL handler and a non-NULL thread_fn, the former runs in hardirq
context and the latter in kthread context. Even on PREEMPT_RT.
So how can aer_irq() and aer_isr() ever both run in kthread context?
Am I missing something?
> at the same FIFO priority. This can lead to the aer_isr thread starving
> the aer_irq thread, particularly if multi_error_valid causes a scan of
> all devices, and multiple errors are raised during the scan.
I'm not seeing aer_isr() waiting on a spinlock, so how can it be starved?
Thanks,
Lukas
next prev parent reply other threads:[~2025-09-03 8:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 22:44 [PATCH] PCI/AER: Use IRQF_NO_THREAD on aer_irq Crystal Wood
2025-09-03 8:10 ` Lukas Wunner [this message]
2025-09-03 21:39 ` Crystal Wood
2025-09-04 7:30 ` Sebastian Andrzej Siewior
2025-09-04 12:48 ` Lukas Wunner
2025-09-04 13:18 ` Lukas Wunner
2025-09-04 13:38 ` Sebastian Andrzej Siewior
2025-09-04 13:31 ` Sebastian Andrzej Siewior
2025-09-04 20:27 ` Crystal Wood
2025-09-08 6:36 ` Lukas Wunner
2025-09-08 7:52 ` Sebastian Andrzej Siewior
2025-09-08 15:02 ` Crystal Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aLf34pnRmk4ip7KS@wunner.de \
--to=lukas@wunner.de \
--cc=afazekas@redhat.com \
--cc=bhelgaas@google.com \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=crwood@redhat.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).