From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65A46635 for ; Mon, 3 Nov 2025 13:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762176065; cv=none; b=byvQSpLmTYsOQxEh2p319qMzcWQHuaqVX7A66kazABSN5IAjCRFxBsp2H+kql3+IDbaY3CkSDjZeN3Om4VCbwjq29RqWJtBFmeRpqlz8Z2zL7sXGw2sD1qRw13XwmtYw55il11HCevx0jkyCf1VIQVJN+Xmo9N8Hksc5rpvWwQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762176065; c=relaxed/simple; bh=sRRgSfVb4QIf574NrhWX8DYiPXNTYRXkxo0qK3N9Hmc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J8ZV3LfVbE7d/0Z3zAdzBy/DM2tnkm2UQ8ogCkivJeQbwsxIliG2yAZWrEuJem4u4R9aqhafGS3WCZQi3CGaTAxdw4sRHvbL5Ves/IMyvnVjd78c8PCtg21OFXjsyFWy3luT6fbGtMbNlSW1/n545fRAJ4QgSjTqBRjXO3vyD/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JWY33MwC; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JWY33MwC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1762176063; x=1793712063; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=sRRgSfVb4QIf574NrhWX8DYiPXNTYRXkxo0qK3N9Hmc=; b=JWY33MwCuP1X0XTnnZbijfEJMLqb0LQt+hIKJEkx0SU/gXff7UDLG7qw coeoIjGLG3OSPSKv1Mb9rR9Y+5tFr0Oolm81BixtnJC/J+cUYuNsput0X p+dQ7VTXQE1FKKKwww+xi8NMlWtQ0dFKM9++fi+xGpjlyINmcQK+s2Hnn 1T0oiQMjrMZZfs9hI+3I2IIGBzXtgUFvjgDjmjwPVj2/wZQ09ufgIWDZc NBaWY4dmsyyJx+SNXSSR77xzM/8BBGRXE/3hlO28BE611+ltKxVcYFNCj z7N/aDWzmqZfAPBqTEJ8f/B0TrZea+0T2WPXv6PYH0cUHyVyvKnxWymn2 Q==; X-CSE-ConnectionGUID: lEHOqxkSRJ+CRUo5tDVckA== X-CSE-MsgGUID: 82TbfZbCRP2BpikN0iSm8A== X-IronPort-AV: E=McAfee;i="6800,10657,11601"; a="64346657" X-IronPort-AV: E=Sophos;i="6.19,276,1754982000"; d="scan'208";a="64346657" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2025 05:21:02 -0800 X-CSE-ConnectionGUID: Ve8s6nGrRYWIFeU9REdqkQ== X-CSE-MsgGUID: N1Bj9SScSDCyG6WvWEaihA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,276,1754982000"; d="scan'208";a="187322237" Received: from smoehrl-linux.amr.corp.intel.com (HELO ashevche-desk.local) ([10.124.220.216]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2025 05:20:58 -0800 Received: from andy by ashevche-desk.local with local (Exim 4.98.2) (envelope-from ) id 1vFuUP-000000059gw-0Jrh; Mon, 03 Nov 2025 15:20:53 +0200 Date: Mon, 3 Nov 2025 15:20:52 +0200 From: Andy Shevchenko To: Mika Westerberg Cc: =?iso-8859-1?Q?Beno=EEt?= Monin , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jarkko Nikula , Jan Dabros , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Thomas Petazzoni , Gregory CLEMENT , =?iso-8859-1?Q?Th=E9o?= Lebrun , Tawfik Bayouk , Vladimir Kondratiev , Dmitry Guzman , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev Subject: Re: [PATCH v2 5/5] i2c: designware: Support of controller with IC_EMPTYFIFO_HOLD_MASTER disabled Message-ID: References: <20251031-i2c-dw-v2-0-90416874fcc0@bootlin.com> <20251031-i2c-dw-v2-5-90416874fcc0@bootlin.com> <20251103104330.GG2912318@black.igk.intel.com> Precedence: bulk X-Mailing-List: linux-rt-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251103104330.GG2912318@black.igk.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Nov 03, 2025 at 11:43:30AM +0100, Mika Westerberg wrote: > On Fri, Oct 31, 2025 at 03:35:43PM +0100, Benoît Monin wrote: ... > > + return (msgs[idx - 1].flags & I2C_M_RD) == (msgs[idx].flags & I2C_M_RD); > > You don't need the outer parens. Priority of == is 10, while & is 11. -- With Best Regards, Andy Shevchenko