Re: [PATCH 07/11] ASoC: dt-bindings: add avdd and iovdd supply

Krzysztof Kozlowski
2025-12-17T14:29:42Z

On 17/12/2025 14:54, Sascha Hauer wrote:
> Add bindings for the avdd-supply and iovdd-supply which are named after
> the corresponding pins on the tlv320adcx140 chips.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml b/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> index 876fa97bfbcdd3b9450aa6ff57de42f1faed350d..0f043a51f1822f4d39214438818e3bc84d3e8681 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> @@ -44,6 +44,16 @@ properties:
> Regulator with AVDD at 3.3V. If not defined then the internal regulator
> is enabled.
>
> + avdd-supply:
> + description: |
> + Provide a handle to the regulator supplying AVDD. If not provided, a dummy
> + regulator will be used.

Drop description, you did not say anything useful. Core already tells
this is phandle, "AVDD" duplicates property name and Linux kernel
behavior is here irrelevant.

If BSD does not create a dummy regulator, does this mean binding is wrong?

The bigger problem is that you are duplicating AVDD already described
under name areg. At least that's my impression and commit msg idd not
clarify anything here.

Best regards,
Krzysztof