Re: [PATCH 08/11] ASoC: dt-bindings: clarify areg-supply documentation

Krzysztof Kozlowski
2025-12-17T14:30:45Z

On 17/12/2025 14:54, Sascha Hauer wrote:
> From: Emil-Juhl <emdj@bang-olufsen.dk>
>
> The documentation for areg-supply could cause confusion mainly in terms
> of the relationship between AREG and AVDD.
> According to the datasheet[1] the AREG can be one of two cases:
>
> 1) an external 1.8V supply
> 2) generated by an internal regulator (hence a 1.8V output)
>
> [1] https://www.ti.com/lit/ds/symlink/tlv320adc5140.pdf
>

Incomplete DCO chain.

> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml b/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> index 0f043a51f1822f4d39214438818e3bc84d3e8681..0c550c04f5ef239f403bea668ffd8c6051d86821 100644
> --- a/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> +++ b/Documentation/devicetree/bindings/sound/ti,tlv320adcx140.yaml
> @@ -41,8 +41,8 @@ properties:
>
> areg-supply:
> description: |
> - Regulator with AVDD at 3.3V. If not defined then the internal regulator
> - is enabled.
> + External supply of 1.8V. If not defined then the internal regulator is
> + enabled instead.

Please re-order the patches. Fixes are always before new features and
you would solve yourself one review question...

Best regards,
Krzysztof