Re: [PATCH 05/11] ASoC: tlv320adcx140: implement register caching

Mark Brown
2025-12-17T14:11:30Z

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

On Wed, Dec 17, 2025 at 02:54:55PM +0100, Sascha Hauer wrote:

> The tlv320adcx140 can be connected to controllable AVDD/IOVDD regulators
> which when disabled will reset the registers to their default. In
> preparation for adding support for them implement register caching.

This patch doesn't actually enable register caching, there's no cache
type specified. Indeed, the driver already has a register cache which
for some reason is REGCACHE_FLAT (which seems rather bogus and will have
defaulted most of the registers to 0 which may or may not be a good
idea). This looks like it's a substantial improvement but the change
doesn't correspond to the changelog.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]