Re: [PATCH v3 15/21] slab: remove struct kmem_cache_cpu

Suren Baghdasaryan
2026-01-21T17:54:39Z

On Wed, Jan 21, 2026 at 2:29 PM Vlastimil Babka <vbabka@suse.cz> wrote:
>
> On 1/20/26 13:40, Hao Li wrote:
> > On Fri, Jan 16, 2026 at 03:40:35PM +0100, Vlastimil Babka wrote:
> >> @@ -3853,7 +3632,7 @@ static bool has_pcs_used(int cpu, struct kmem_cache *s)
> >> }
> >>
> >> /*
> >> - * Flush cpu slab.
> >> + * Flush percpu sheaves
> >> *
> >> * Called from CPU work handler with migration disabled.
> >> */
> >> @@ -3868,8 +3647,6 @@ static void flush_cpu_slab(struct work_struct *w)
> >
> > Nit: Would it make sense to rename flush_cpu_slab to flush_cpu_sheaf for better
> > clarity?
>
> OK
>
> > Other than that, looks good to me. Thanks.
> >
> > Reviewed-by: Hao Li <hao.li@linux.dev>

I noticed one hit on deactivate_slab in the comments after applying
the entire patchset. Other than that LGTM.

Reviewed-by: Suren Baghdasaryan <surenb@google.com>

>
> Thanks!
>