Re: [PATCH 18/21] iio: Replace IRQF_ONESHOT with IRQF_NO_THREAD

Andy Shevchenko
2026-01-26T09:51:20Z

On Mon, Jan 26, 2026 at 09:15:10AM +0100, Sebastian Andrzej Siewior wrote:
> On 2026-01-23 16:48:54 [+0200], Andy Shevchenko wrote:
> > On Fri, Jan 23, 2026 at 12:37:04PM +0100, Sebastian Andrzej Siewior wrote:

...

> > > Cc: Lars-Peter Clausen <lars@metafoo.de>
> > > Cc: Michael Hennerich <Michael.Hennerich@analog.com>
> > > Cc: Puranjay Mohan <puranjay@kernel.org>
> > > Cc: Jonathan Cameron <jic23@kernel.org>
> > > Cc: David Lechner <dlechner@baylibre.com>
> > > Cc: "Nuno Sá" <nuno.sa@analog.com>
> > > Cc: Andy Shevchenko <andy@kernel.org>
> > > Cc: Marcelo Schmitt <marcelo.schmitt@analog.com>
> > > Cc: Marcus Folkesson <marcus.folkesson@gmail.com>
> > > Cc: Kent Gustavsson <kent@minoris.se>
> > > Cc: Gustavo Silva <gustavograzs@gmail.com>
> > > Cc: Nishant Malpani <nish.malpani25@gmail.com>
> > > Cc: linux-iio@vger.kernel.org
> >
> > Move these...
> >
> > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > > ---
> >
> > ...to be here. This will drastically reduce the unneeded noise in the commit
> > message. The email will have (if using git format-patch and git send-email)
> > them.
>
> Yeah but if I have to send v2 then they are gone, aren't they?

I didn't follow. How? What tools do you use?

> So I have to move them for each submission. Or is there something I am not
> aware of?

Make them in the tail of commit messages locally with a delimiter, they will
always be present as long as they are in your tree.

I dunno if `b4` manages the Cc lists separately. At least I see no-one using
`b4` *and* putting the Cc noise into the commit messages, so I assume it
behaves nicely.

...

> > > + ret = devm_request_irq(dev, st->irq,
> > > + iio_trigger_generic_data_rdy_poll,
> > > + IRQF_TRIGGER_RISING | IRQF_NO_THREAD,
> > > + indio_dev->name, st->dready_trig);
> > > if (ret < 0)
> > > return ret;
> >
> > Interestingly that this driver ignores the flags from firmware... Seems to me
> > like a bug (not in your patch, obviously). Ditto for other drivers doing similar
> > things.
>
> If the irq-chip is level or unknown mode on boot up/ default and the
> device can only operate as an edge-rising then I don't see why this
> should be a bug.

But if FW says use "level", wouldn't this setting override it?

--
With Best Regards,
Andy Shevchenko