Re: [PATCH 02/21] platform/x86: int0002: Remove IRQF_ONESHOT from request_irq()

Ilpo Järvinen
2026-01-26T14:05:07Z

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

On Fri, 23 Jan 2026, Sebastian Andrzej Siewior wrote:

> On 2026-01-23 12:36:48 [+0100], To linux-kernel@vger.kernel.org wrote:
> > Passing IRQF_ONESHOT ensures that the interrupt source is masked until
> > the secondary (threaded) handler is done. If only a primary handler is
> > used then the flag makes no sense because the interrupt can not fire
> > (again) while its handler is running.
> > The flag also disallows force-threading of the primary handler and the
> > irq-core will warn about this.
> >
> > The flag was added to match the flag on the shared handler which uses a
> > threaded handler and therefore IRQF_ONESHOT. This is no longer needed
> > because devm_request_irq() now passes IRQF_COND_ONESHOT for this case.
> >
> > Revert adding IRQF_ONESHOT to irqflags.
>
> This one should probably go hand in hand with the previous one. It might
> be easier to route both via tip/irq.

For that,

Acked-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.