Re: [PATCH 18/21] iio: Replace IRQF_ONESHOT with IRQF_NO_THREAD

David Lechner
2026-01-23T21:00:21Z

On 1/23/26 10:47 AM, Jonathan Cameron wrote:
>
>>> +++ b/drivers/iio/accel/adxl372.c
>>
>>> + ret = devm_request_irq(dev, st->irq,
>>> + iio_trigger_generic_data_rdy_poll,
>>> + IRQF_TRIGGER_RISING | IRQF_NO_THREAD,
>>> + indio_dev->name, st->dready_trig);
>>> if (ret < 0)
>>> return ret;
>>
>> Interestingly that this driver ignores the flags from firmware... Seems to me
>> like a bug (not in your patch, obviously). Ditto for other drivers doing similar
>> things.
>>
>
> It's indeed a bug but one of those historic ones we can't fix without
> high risk of regressions :(
>
>
Sounds like we should add a "don't copy this because ..." comment while we
are touching this.