From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CB042F5337 for ; Mon, 26 Jan 2026 09:51:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769421083; cv=none; b=qGQhV1l1fKyw961nNTc33z4fN4SVQPsGqkIB85IghzGfehUj0iATFw2/5JTbVZbw9ZvYY1UPfsKMUYsDcZpNadrtSNOPwkXtBo8VHUr75lLP8pJxXz7hSWQQ4lFmg1R6opsoL0481qfRCNqCrUAdgCcJ7DimYhpqqsZbHK44Gso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769421083; c=relaxed/simple; bh=0B+ki7zm3XlFyUpJlEmR6BoipBh4Fb3jpboWMAe4HL0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Uao1uGPOdzrSkhejtthx5XSs5nHWpOEBmLr1Zm99kcG8f3N8ZNBTZl85gM4pYVU+SAC0fgcTsQU8pSkgsl9kuv1qhxgDebO7j8WQaOHOQmun9LM3X0LPX/gFGCIiXJVpZxu8svvTb+07t/fi4PYP9vuItTQ8PBsAd4MxvoRIFgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OBmruUHJ; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OBmruUHJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769421081; x=1800957081; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=0B+ki7zm3XlFyUpJlEmR6BoipBh4Fb3jpboWMAe4HL0=; b=OBmruUHJ7h1XRN9ojCsVicjupnWe1h8lYUTgg8iZmLXSxi6SDLEdI2m6 tUtMEYYwwh8jqK5OHgJ1IzhIIadVijfuKBEa4zYQCWuQfLTJfcG58DlrS 9xsOvRu98tbH/tddjp1zizX4WF8zITTTrkYtCdTrosl5E47H9jc4OlLSt jF1M8nCS8R4x2Bjp4YEKpyIAU0c8rfTVhGIptU1A1Pp9oZ4goPOlfIuW9 nnp/HkPBKymPXk5JU7XNTe8rXmJd0E3tzU6oayjSCmyK0sZ5JN5i4UpvV 76lFlYe5aAH99uooJk/MbFDCGeYj4hKCfTEYlgpaLwnsEbT9E55Ht5uWH A==; X-CSE-ConnectionGUID: 7s9Ntp/mSG6yRyYaDilm/Q== X-CSE-MsgGUID: 8AYlfhamR5CDsacBAy64Cw== X-IronPort-AV: E=McAfee;i="6800,10657,11682"; a="74437910" X-IronPort-AV: E=Sophos;i="6.21,254,1763452800"; d="scan'208";a="74437910" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2026 01:51:20 -0800 X-CSE-ConnectionGUID: GuPCQ1lgSm6FdVtZjTBqsw== X-CSE-MsgGUID: 2SFYT0vIQs6qbvwryJBCgw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,254,1763452800"; d="scan'208";a="245249365" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.122]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2026 01:51:15 -0800 Date: Mon, 26 Jan 2026 11:51:13 +0200 From: Andy Shevchenko To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Thomas Gleixner , Lars-Peter Clausen , Michael Hennerich , Puranjay Mohan , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Marcelo Schmitt , Marcus Folkesson , Kent Gustavsson , Gustavo Silva , Nishant Malpani , linux-iio@vger.kernel.org Subject: Re: [PATCH 18/21] iio: Replace IRQF_ONESHOT with IRQF_NO_THREAD Message-ID: References: <20260123113708.416727-1-bigeasy@linutronix.de> <20260123113708.416727-19-bigeasy@linutronix.de> <20260126081510.jr8Rp6R7@linutronix.de> Precedence: bulk X-Mailing-List: linux-rt-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260126081510.jr8Rp6R7@linutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Jan 26, 2026 at 09:15:10AM +0100, Sebastian Andrzej Siewior wrote: > On 2026-01-23 16:48:54 [+0200], Andy Shevchenko wrote: > > On Fri, Jan 23, 2026 at 12:37:04PM +0100, Sebastian Andrzej Siewior wrote: ... > > > Cc: Lars-Peter Clausen > > > Cc: Michael Hennerich > > > Cc: Puranjay Mohan > > > Cc: Jonathan Cameron > > > Cc: David Lechner > > > Cc: "Nuno Sá" > > > Cc: Andy Shevchenko > > > Cc: Marcelo Schmitt > > > Cc: Marcus Folkesson > > > Cc: Kent Gustavsson > > > Cc: Gustavo Silva > > > Cc: Nishant Malpani > > > Cc: linux-iio@vger.kernel.org > > > > Move these... > > > > > Signed-off-by: Sebastian Andrzej Siewior > > > --- > > > > ...to be here. This will drastically reduce the unneeded noise in the commit > > message. The email will have (if using git format-patch and git send-email) > > them. > > Yeah but if I have to send v2 then they are gone, aren't they? I didn't follow. How? What tools do you use? > So I have to move them for each submission. Or is there something I am not > aware of? Make them in the tail of commit messages locally with a delimiter, they will always be present as long as they are in your tree. I dunno if `b4` manages the Cc lists separately. At least I see no-one using `b4` *and* putting the Cc noise into the commit messages, so I assume it behaves nicely. ... > > > + ret = devm_request_irq(dev, st->irq, > > > + iio_trigger_generic_data_rdy_poll, > > > + IRQF_TRIGGER_RISING | IRQF_NO_THREAD, > > > + indio_dev->name, st->dready_trig); > > > if (ret < 0) > > > return ret; > > > > Interestingly that this driver ignores the flags from firmware... Seems to me > > like a bug (not in your patch, obviously). Ditto for other drivers doing similar > > things. > > If the irq-chip is level or unknown mode on boot up/ default and the > device can only operate as an edge-rising then I don't see why this > should be a bug. But if FW says use "level", wouldn't this setting override it? -- With Best Regards, Andy Shevchenko