Re: [PATCH 09/21] char: tpm: cr50: Remove IRQF_ONESHOT

Jarkko Sakkinen
2026-01-25T16:50:05Z

On Fri, Jan 23, 2026 at 12:36:55PM +0100, Sebastian Andrzej Siewior wrote:
> Passing IRQF_ONESHOT ensures that the interrupt source is masked until
> the secondary (threaded) handler is done. If only a primary handler is
> used then the flag makes no sense because the interrupt can not fire
> (again) while its handler is running.
> The flag also disallows force-threading of the primary handler and the
> irq-core will warn about this.
>
> Remove IRQF_ONESHOT from irqflags.
>
> Cc: Peter Huewe <peterhuewe@gmx.de>
> Cc: Jarkko Sakkinen <jarkko@kernel.org>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: linux-integrity@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> drivers/char/tpm/tpm_tis_i2c_cr50.c | 3 +--
> drivers/char/tpm/tpm_tis_spi_cr50.c | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_tis_i2c_cr50.c b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> index fc6891a0b6936..b48cacacc0664 100644
> --- a/drivers/char/tpm/tpm_tis_i2c_cr50.c
> +++ b/drivers/char/tpm/tpm_tis_i2c_cr50.c
> @@ -749,8 +749,7 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client)
>
> if (client->irq > 0) {
> rc = devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler,
> - IRQF_TRIGGER_FALLING | IRQF_ONESHOT |
> - IRQF_NO_AUTOEN,
> + IRQF_TRIGGER_FALLING | IRQF_NO_AUTOEN,
> dev->driver->name, chip);
> if (rc < 0) {
> dev_err(dev, "Failed to probe IRQ %d\n", client->irq);
> diff --git a/drivers/char/tpm/tpm_tis_spi_cr50.c b/drivers/char/tpm/tpm_tis_spi_cr50.c
> index f4937280e9406..32920b4cecfb4 100644
> --- a/drivers/char/tpm/tpm_tis_spi_cr50.c
> +++ b/drivers/char/tpm/tpm_tis_spi_cr50.c
> @@ -287,7 +287,7 @@ int cr50_spi_probe(struct spi_device *spi)
> if (spi->irq > 0) {
> ret = devm_request_irq(&spi->dev, spi->irq,
> cr50_spi_irq_handler,
> - IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> + IRQF_TRIGGER_RISING,
> "cr50_spi", cr50_phy);
> if (ret < 0) {
> if (ret == -EPROBE_DEFER)
> --
> 2.51.0
>

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

Shoud I pick this? I did apply it to my master branch (not next).

BR, Jarkko