Re: [PATCH 11/21] i2c: spacemit: Remove IRQF_ONESHOT

Yixun Lan
2026-01-23T20:53:24Z

Hi Sebastian,

On 12:36 Fri 23 Jan , Sebastian Andrzej Siewior wrote:
> Passing IRQF_ONESHOT ensures that the interrupt source is masked until
> the secondary (threaded) handler is done. If only a primary handler is
> used then the flag makes no sense because the interrupt can not fire
> (again) while its handler is running.
> The flag also disallows force-threading of the primary handler and the
> irq-core will warn about this.
>
> Remove IRQF_ONESHOT from irqflags.
>

I've sent out a similar patch which already accepted and queued, see
https://lore.kernel.org/r/20260122-05-k1-i2c-irq-v1-1-9b8d94bbcd22@kernel.org

> Cc: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> Cc: Andi Shyti <andi.shyti@kernel.org>
> Cc: Yixun Lan <dlan@gentoo.org>
> Cc: linux-i2c@vger.kernel.org
> Cc: linux-riscv@lists.infradead.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> drivers/i2c/busses/i2c-k1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c
> index d42c03ef5db59..8ef6d5d1927b7 100644
> --- a/drivers/i2c/busses/i2c-k1.c
> +++ b/drivers/i2c/busses/i2c-k1.c
> @@ -566,7 +566,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev)
> return dev_err_probe(dev, i2c->irq, "failed to get irq resource");
>
> ret = devm_request_irq(i2c->dev, i2c->irq, spacemit_i2c_irq_handler,
> - IRQF_NO_SUSPEND | IRQF_ONESHOT, dev_name(i2c->dev), i2c);
> + IRQF_NO_SUSPEND, dev_name(i2c->dev), i2c);
> if (ret)
> return dev_err_probe(dev, ret, "failed to request irq");
>
> --
> 2.51.0
>

--
Yixun Lan (dlan)