From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87B32334372; Thu, 5 Feb 2026 21:59:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770328759; cv=none; b=UYcvLjw5alpOx0oTOBBQD8aIBpM21ZSS31pWl199NTzb4JP4o56n2fUzpyp2cU0AclvdveSwZCT+T5YsGluGTIGT3gVR+EnfVp0Gjyq3RHgM2fiRHYcwa9vMQbIaYYGr6FK/9qeoXPvc/wJrgyQhJe7RJBPlXzw3qSRwJmPNKhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770328759; c=relaxed/simple; bh=sXaQ57x8gSeRJX5gWFkQTz7yJFcTWOilg+QmXgs9m6Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L1XZnRlElmFSsajE1s48nm/MJrGLE3scuFEtm+Lmir7KKiQIP8LaO+/h/SbWIuWwkXUwNljcTGjSXRJFZArdQLmYE9b94Asy5iCPoC2HdePZJoMTeKl21d7mq0dSbTzpASnk+ukjof8oVnR7hHpl+G9sPLH9uVE2iTKDr3wcgpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L4t6PqdQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L4t6PqdQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB7E1C4CEF7; Thu, 5 Feb 2026 21:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770328759; bh=sXaQ57x8gSeRJX5gWFkQTz7yJFcTWOilg+QmXgs9m6Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L4t6PqdQ1vXDthoqYT2aAQkUlnGi8ljA64R9Lhve7Kc33R4fj7FMpuSJsF4/WYuqp 9dtf3OSQV9g/9mzltII93iCCWmtlqBlflaUPg6Oa3wkI/GAPFrKSQC9eAahLFrl03l Ef7jOiJw1Jo5ZJvVXBua4hRYO1KP4ObKEQXIIthaTfZN+FLyq/FG3Z45JjShEpgbWT Z/lxwaMKmDifVRS2Me/ubvgAbe5Ttf0sGvIoGyFJlms50q9BiSLUrAZci4hS9xNZpk Tqa1UvDXFZWbhA0pSQmOsnxJZaKMnY6DKsMTVf3+A1hSTpj94mFGR/S7VO6zIIk0fm lXaHa818MgHsA== Date: Thu, 5 Feb 2026 11:59:17 -1000 From: Tejun Heo To: Sebastian Andrzej Siewior Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, "Luis Claudio R. Goncalves" , Ard Biesheuvel , John Ogness , Lai Jiangshan , Thomas =?iso-8859-1?Q?Wei=DFschuh?= Subject: Re: [PATCH 1/2] workqueue: Allow to expose ordered workqueues via sysfs Message-ID: References: <20260205115559.1625236-1-bigeasy@linutronix.de> <20260205115559.1625236-2-bigeasy@linutronix.de> <20260205133913.538FuakM@linutronix.de> Precedence: bulk X-Mailing-List: linux-rt-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260205133913.538FuakM@linutronix.de> On Thu, Feb 05, 2026 at 02:39:13PM +0100, Sebastian Andrzej Siewior wrote: > +static umode_t wq_sysfs_is_visible(struct kobject *kobj, struct attribute *a, int n) > +{ > + struct device *dev = kobj_to_dev(kobj); > + struct workqueue_struct *wq = dev_to_wq(dev); > + > + /* > + * Adjusting max_active breaks ordering guarantee. Changing it has no > + * effect on BH worker. Limit max_active to RO in such case. > + */ > + if (wq->flags & (WQ_BH | __WQ_ORDERED)) > + return 0444; > + return a->mode; > +} > + > +static const struct attribute_group wq_sysfs_group = { > + .is_visible = wq_sysfs_is_visible, > + .attrs = wq_sysfs_attrs, > +}; > +__ATTRIBUTE_GROUPS(wq_sysfs); Yeah, this looks fine to me. Thanks. -- tejun