From: Crystal Wood <crwood@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Lukas Wunner <lukas@wunner.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Attila Fazekas <afazekas@redhat.com>,
linux-pci@vger.kernel.org, linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH] PCI/AER: Use IRQF_NO_THREAD on aer_irq
Date: Mon, 08 Sep 2025 10:02:09 -0500 [thread overview]
Message-ID: <ad1f8cbe29e27dc70db136af5888774ab0b46288.camel@redhat.com> (raw)
In-Reply-To: <20250908075225.sDW_dYzG@linutronix.de>
On Mon, 2025-09-08 at 09:52 +0200, Sebastian Andrzej Siewior wrote:
> On 2025-09-08 08:36:32 [+0200], Lukas Wunner wrote:
> > --- a/kernel/sched/syscalls.c
> > +++ b/kernel/sched/syscalls.c
> > @@ -847,6 +847,15 @@ void sched_set_fifo(struct task_struct *p)
> > EXPORT_SYMBOL_GPL(sched_set_fifo);
> >
> > /*
> > + * Secondary IRQ handler has slightly lower priority than primary IRQ handler.
>
> For tasks that should be sched_set_fifo() but require not to preempt
> another sched_set_fifo() task.
SCHED_FIFO already means that tasks of the same priority won't preempt
each other. I'd word it as:
For tasks that must be preemptible by a sched_set_fifo() task, such as
to simulate the behavior of a non-PREEMPT_RT system where the
sched_set_fifo() task is a hard interrupt.
-Crystal
prev parent reply other threads:[~2025-09-08 15:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 22:44 [PATCH] PCI/AER: Use IRQF_NO_THREAD on aer_irq Crystal Wood
2025-09-03 8:10 ` Lukas Wunner
2025-09-03 21:39 ` Crystal Wood
2025-09-04 7:30 ` Sebastian Andrzej Siewior
2025-09-04 12:48 ` Lukas Wunner
2025-09-04 13:18 ` Lukas Wunner
2025-09-04 13:38 ` Sebastian Andrzej Siewior
2025-09-04 13:31 ` Sebastian Andrzej Siewior
2025-09-04 20:27 ` Crystal Wood
2025-09-08 6:36 ` Lukas Wunner
2025-09-08 7:52 ` Sebastian Andrzej Siewior
2025-09-08 15:02 ` Crystal Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad1f8cbe29e27dc70db136af5888774ab0b46288.camel@redhat.com \
--to=crwood@redhat.com \
--cc=afazekas@redhat.com \
--cc=bhelgaas@google.com \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=lukas@wunner.de \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).