From: Karl Mehltretter <kmehltretter@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: John Ogness <john.ogness@linutronix.de>,
sashiko-reviews@lists.linux.dev, Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH 2/2] serial: amba-pl011: keep console clock enabled for atomic writes
Date: Mon, 20 Jul 2026 23:26:46 +0200 [thread overview]
Message-ID: <al6M1gwuWfk2wqwI@gmail.com> (raw)
In-Reply-To: <20260720082640.eGsVn61E@linutronix.de>
On Mon, Jul 20, 2026 at 10:26:40AM +0100, Sebastian Andrzej Siewior wrote:
> On 2026-07-20 10:19:58 [+0206], John Ogness wrote:
> > This is what the suspend/resume pm callbacks are for. In this case, it
> > is pl011_suspend() and pl011_resume().
>
> Perfect so everything is in place except for these two.
>
> > > There is also this no_console_suspend argument…
> >
> > Yes, the callbacks need to check @console_suspend_enabled. If false, the
> > clocks obviously must not be disabled.
>
> good.
>
All right, I will send a v2 patch for this.
My testing is limited to QEMU, so I cannot test the power impact or
behaviour of real SoCs.
Karl
next prev parent reply other threads:[~2026-07-20 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 6:35 [PATCH 0/2] serial: amba-pl011: fix console clock lifetime Karl Mehltretter
2026-07-19 6:35 ` [PATCH 1/2] serial: amba-pl011: unprepare console clock on unregister Karl Mehltretter
2026-07-19 7:04 ` sashiko-bot
2026-07-19 10:27 ` Karl Mehltretter
2026-07-19 6:35 ` [PATCH 2/2] serial: amba-pl011: keep console clock enabled for atomic writes Karl Mehltretter
2026-07-19 6:52 ` sashiko-bot
2026-07-20 8:01 ` Sebastian Andrzej Siewior
2026-07-20 8:13 ` John Ogness
2026-07-20 8:26 ` Sebastian Andrzej Siewior
2026-07-20 21:26 ` Karl Mehltretter [this message]
2026-07-20 11:45 ` Petr Mladek
2026-07-20 12:15 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al6M1gwuWfk2wqwI@gmail.com \
--to=kmehltretter@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=pmladek@suse.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox