From: Gabriele Monaco <gmonaco@redhat.com>
To: Yunseong Kim <ysk@kzalloc.com>, Nam Cao <namcao@linutronix.de>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
rostedt@goodmis.org, Tomas Glozar <tglozar@redhat.com>,
Shung-Hsi Yu <shung-hsi.yu@suse.com>,
Byungchul Park <byungchul@sk.com>,
syzkaller@googlegroups.com, linux-rt-devel@lists.linux.dev,
LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [Question] Detecting Sleep-in-Atomic Context in PREEMPT_RT via RV (Runtime Verification) monitor rtapp:sleep
Date: Mon, 22 Dec 2025 08:40:30 +0100 [thread overview]
Message-ID: <ee8474631ce309539918e17b60e4ca150327115d.camel@redhat.com> (raw)
In-Reply-To: <0d06ce4c-6ff2-401a-90d9-5a4dfd2abebb@kzalloc.com>
On Thu, 2025-12-11 at 16:58 +0900, Yunseong Kim wrote:
> I am currently considering how to model this to cover cases that go
> beyond what CONFIG_DEBUG_ATOMIC_SLEEP covers.
>
> My specific concern is about custom functions where might_sleep() might
> be missing. In such cases, if the code hits a fast path (no scheduling),
> CONFIG_DEBUG_ATOMIC_SLEEP won't trigger. I'm wondering if RV can detect
> these potential bugs.
Hi Yunseong,
I finally got to reflect a bit more on this.
As we discussed at LPC, RV wouldn't help with not annotated functions because
you'd need to add tracepoints there, so probably the best is to just add a
might_sleep and be done with it.
Other than that, I double checked and CONFIG_DEBUG_ATOMIC_SLEEP is in fact
disabled on non-debug kernels in Fedora/RHEL (and I presume also in Debian and
friends), so the other concern you raised is indeed valid.
Although perhaps rather unlikely, I'm not sure we can completely rule out cases
in which non-debug kernel (where several other debugging features besides
CONFIG_DEBUG_ATOMIC_SLEEP are disabled) behave differently enough for some bugs,
otherwise invisible on debug kernels, to pop up.
Another use could be debugging kernel modules on non-debug kernels, perhaps to
avoid some other debug features to be present while still relying on the
packaged kernel.
For this to work you'd need to add a tracepoint on might_sleep when
CONFIG_DEBUG_ATOMIC_SLEEP is disabled (and it's currently a NOP), hopefully that
wouldn't make people too angry.
Again, none of this would be ground-breaking but it doesn't look useless either.
Any thoughts?
Thanks,
Gabriele
next prev parent reply other threads:[~2025-12-22 7:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 6:54 [Question] Detecting Sleep-in-Atomic Context in PREEMPT_RT via RV (Runtime Verification) monitor rtapp:sleep Yunseong Kim
2025-10-27 12:20 ` Gabriele Monaco
2025-10-28 22:53 ` Yunseong Kim
2025-10-29 9:24 ` Gabriele Monaco
2025-11-05 9:10 ` Nam Cao
2025-12-02 11:14 ` Nam Cao
2025-12-02 11:26 ` Sebastian Andrzej Siewior
2025-12-11 4:30 ` Yunseong Kim
2025-12-11 5:42 ` Nam Cao
2025-12-11 7:58 ` Yunseong Kim
2025-12-22 7:40 ` Gabriele Monaco [this message]
2025-12-23 14:31 ` Yunseong Kim
2025-12-23 15:21 ` Gabriele Monaco
2025-12-12 7:02 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee8474631ce309539918e17b60e4ca150327115d.camel@redhat.com \
--to=gmonaco@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=byungchul@sk.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=namcao@linutronix.de \
--cc=rostedt@goodmis.org \
--cc=shung-hsi.yu@suse.com \
--cc=syzkaller@googlegroups.com \
--cc=tglozar@redhat.com \
--cc=ysk@kzalloc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox