From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A15236FC5 for ; Tue, 17 Mar 2026 19:30:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773775851; cv=fail; b=owH2QZK3Vub4mMn+b7MG5ssiQl8ZnzaubpBz4w4g9CcskNcywv2nuOKfMtnj2ffGmNwjmnskmh3Ryg6eE6G53BADJ1wiGc7q301yYZJmaW5cCHv7+TDbax08HC28pV39hlSUXvVsrTH1vLmPuBHzP2fMUXQt8IIOPMq4Q09AdsE= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773775851; c=relaxed/simple; bh=W44SxiM12rwYuYS2n7pZgOTDkJfQqZn3l2eBNgY91iI=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=af1pbT52mcUiGbssw4Q+VcG1dLxQxQM0ZSdVYZuWj2IgV8hOmlMohrQqfcGpvf1jwNZNA+C99+QIBvr/TovPGgju8jXhtJSXaf7bSlgC5WAZhOczwl/+COmL4OCBph67aODZuJU8LgQe946nrTQX4aj+G31DfB3wRG9v6kNn7oo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Xjqp82aY; arc=fail smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Xjqp82aY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773775848; x=1805311848; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=W44SxiM12rwYuYS2n7pZgOTDkJfQqZn3l2eBNgY91iI=; b=Xjqp82aYjXnch5+LmULHGqNFbrG16ewVtoB00AtZXMfnCcO0XxrU9rZD Cg3kyRGqLvwqLR5/AkwkeS+Jw2POepLl8aINZ61VjCRxgBIMchK/y6fD5 ZBZ4Z26qpKkR/G11eto8pebA33Myu3e7k+BF8HcsYKVMbwVQQgwDDblY3 XvqnEUtK7Il7D7cbn1S0IDcdOd5GNPZXV8olrCsLkTTWw46bkP2j//12y wFM0KaG3IOOX2Or21Dff+oiPr0hEI7t+28vI+ophoVZEEuaO2+GJpe5c1 AT1S1VNGGPGQ3hFljxJtFjyvhKLtMMtxtNjpqc0Xw3mpQiFGWh18+fXtf w==; X-CSE-ConnectionGUID: 5bBTehJjRfKa4lWCH1nJtA== X-CSE-MsgGUID: Hfmk46blTi2dQLwEKYNAew== X-IronPort-AV: E=McAfee;i="6800,10657,11732"; a="74737979" X-IronPort-AV: E=Sophos;i="6.23,126,1770624000"; d="scan'208";a="74737979" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2026 12:30:48 -0700 X-CSE-ConnectionGUID: NVGvoFYTTPexVhDcpruH1A== X-CSE-MsgGUID: qF/lRvgEQ9aTgInFLqQfjw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,126,1770624000"; d="scan'208";a="224512004" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2026 12:30:48 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 17 Mar 2026 12:30:47 -0700 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 17 Mar 2026 12:30:47 -0700 Received: from SA9PR02CU001.outbound.protection.outlook.com (40.93.196.43) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 17 Mar 2026 12:30:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kQY9G0uQN1PdjLzQOHHGqfIDCSTHiQSlaswYhQ/kAlOIILL/qiwUAvFqfHw1qiiqkcMC+RozFsnzpOLXpeTigxJKzStVTfXH/zWBnUEQ4Mw2YCg9r/QIUhpPc/QmjwyoU26ELYaoabRapx5p2jgf5k0YV8h17RmLhEqTmHMnZEYYZh5nfrIh+LX1O0YXE3tv76HAqannH8Sk2HAr0lFZMt0I9xZ1KguYYTaUcZXV4Q5Q2i8TRyDcI4ZHVa6wKi2mst0ORrU62cjMKRVroS0uzFSbqkydU6lCaXmv+NXXSW7+tpAaaUYYp7s9SRNZwjK9TC9JWms+qivMYx1DSaEnJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m7wQf00CXyQjGVzrxM2BeEQF7n6Yeq03bdrDPk0QOjY=; b=jPd9LkAeUeInGNlYS6AZQh2IPIO5H63DJGEOgAzw5urKYBGS8E8Zh281iM3g/9xjpmL/jAnPr6QdHyrU204QMuxRhxR4YcgNtrl7B1xIEszwAiUw3qI01IX0Y6cpl7Ycmq3sgvFUrS6T7GdfqS9HFXV33icuWuDPsQTzH/QGEJyrUx6SnwyytDCTPzpux0jV9LgE29KFE1Clk9COM+SRjOy/2p5BHVvp/ICuhrtjRL3X4iFqwQ9kNrdIHnm+bUDU1MzEzdYjndaOlX8Tn1veVwXRkr40i3jmiwX5pb1IseRa5aiO6rzgQvUS+bNkvdEmmUn2EcKE54XQo238WJPx4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MN6PR11MB8172.namprd11.prod.outlook.com (2603:10b6:208:478::9) by MW3PR11MB4649.namprd11.prod.outlook.com (2603:10b6:303:5b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9723.19; Tue, 17 Mar 2026 19:30:44 +0000 Received: from MN6PR11MB8172.namprd11.prod.outlook.com ([fe80::a60e:30b5:37bb:ecfb]) by MN6PR11MB8172.namprd11.prod.outlook.com ([fe80::a60e:30b5:37bb:ecfb%4]) with mapi id 15.20.9723.014; Tue, 17 Mar 2026 19:30:44 +0000 Message-ID: Date: Tue, 17 Mar 2026 12:30:39 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH iwl-net 0/3] idpf: virtchnl locking and async fixes To: Sebastian Andrzej Siewior CC: , , , , , , , , , , , , , , References: <20260316232819.6872-1-emil.s.tantilov@intel.com> <20260317090054.DuPZ6O0O@linutronix.de> <7247024b-fc8d-4a75-ba15-a10399db03bc@intel.com> <20260317143850.BLrnAox8@linutronix.de> Content-Language: en-US From: "Tantilov, Emil S" In-Reply-To: <20260317143850.BLrnAox8@linutronix.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0154.namprd03.prod.outlook.com (2603:10b6:303:8d::9) To MN6PR11MB8172.namprd11.prod.outlook.com (2603:10b6:208:478::9) Precedence: bulk X-Mailing-List: linux-rt-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN6PR11MB8172:EE_|MW3PR11MB4649:EE_ X-MS-Office365-Filtering-Correlation-Id: d0b47638-b3c0-4c1d-4514-08de845bae6c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: MDd3vrmgZvhFZE85OWqht9juvrHnIuRVh8slZopICr6jtN07dleipruSuYRDh8258Jn2s+SkMECHIGGDiePDA0F4/d09dvG+A1qy2AmkFv+l4qgmGbLz2A6ePEOoCOf7cFkeACu+G4vg15QqGMWZ2EdvcrPwGh7Lvru9JXIKS+pSHSIjXKk3zSmRKiSieYahdOBfC7ouSZsN4IxlYgJOPCsSqlQwaK1qhxa1bPbDfVLYYMzgsPRrFS4ZGnPxexneGOK+jqYlgzV+TBzTWVCp0eX/baxnBax+xxm2Uu/3jM8o7KPRcQ0cJZPFVh1HW7+f52uLqOqrV1hXDOUpTg+cKBfoDA237NkXCZhGcrkr9JT5gCTQaj+MFcPDy+gD3VE1WwTxbB/qOcjIkt/8QaZz8cXAtNx2WVjNxaeYUndcKDBh5/3CHL2rI5iScKw9B77/d+ogz7hI0v7+WMiTBAZacUtFuK0FfNjxnRQdOC4k5rH7P7biBYjrsBJHaGhm2KqA5zb9izEYx4pxpK/9pks7AqczHWSVF3amt3DOQzGPSjA9Rga2GWyTlmoVW64lLShCZFUg+HHTJVqWZzM/qaqC6wAOnP6yUp8XSEXcj/TrVakf1GcTbggy+B6IyAoJ1mXrBFfbl748XTq83h70sDLgQ6HLn1603LEfwtlg/17L1mqcsqrQsGgrigTZ3opW1xQr X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8172.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVZOSXNUbjRCVlBaUWtBRVhiTTk5ZldMSXZqRGJXWEpvdTlZd0pXbUZVU1Zm?= =?utf-8?B?SGtNZnczNWp2L1ZSc0djVWRBMDAvcWNuOTJsUnBoSFplS0tCWjBaMVNaelE3?= =?utf-8?B?LzdmZ0ZGZXlpR1MzSit6ZDdMRFU3THk1eFFBNVpucDlzbWlwakoySGFvdzV4?= =?utf-8?B?aHZEVkZMaWZwMHRNWGVubGZjMmYvRFFuUHk3Q2ZSWlgzdkJwR1E5YWk0dy9V?= =?utf-8?B?MlQvSDBDN0ZpNzJ4cEp0U2lHbEc2WDlNZVRQL2lwbTI4bFVGdXUwZVhvU1Fx?= =?utf-8?B?cVBJWHBLZGZoQ0FCT2tPWUVES25EYkFiTlAvSFM1Rjk2VlJFOEVpRXA0T0cz?= =?utf-8?B?S3Q2SThKMXBuUXMrMERsa2RjdmhqNWhiWjk5NGtLc1A1N3hPWVRteUtoNVJl?= =?utf-8?B?RExnN3lER1hnVmtxNjU2UEpuZUhDSGV6ZGQyUHBmVVppWWp0SWdpclhTblI4?= =?utf-8?B?eng3Qkc3RndlRVpjV2NtdUZiWVp6YjBmNWJKSTRZMU9Ib21Ka3BFOUZxVnFN?= =?utf-8?B?dGJ2L0NSemoyTndTUGFabGRHMFA3bmxuWHNEVXptVWZUQUJvTy9qcWJqVTRD?= =?utf-8?B?QUtFTXlEcXQzNWtoUEFEQjNkNDFlbGo3VkpwOHJFYmp5L2hXRlRBSWl6dlQw?= =?utf-8?B?dGNxbGkvY1V0OTZ0YUp6M09SRVVqQ24vL0lmRkNYczJWck9RZHZwOUJUaWY2?= =?utf-8?B?dENseHZRTVpQWkwzRlFQNENRTE0wU05Sa09wSHZzWGo0dmxWOUJacVlrZVY4?= =?utf-8?B?bWRVaXNXL0JQVm1qd3Q1ak5uQWptK2RoVDNyZTVTaEszNEZrc0I1VHdVY3JE?= =?utf-8?B?ZkJtMzl5ZXZoSnkwNkNEUDhGYTNYUVVZTnBBOHR6NFEvUG8wOFo2YlpseTdC?= =?utf-8?B?SzBneEV3anp5V1BxdFFwODdBNklVRDdkRlJ1UVFzZUwwVzc0RXhPYUg2N1NZ?= =?utf-8?B?M2I0MDJtYlpucWxoS0VYRjVqTkFHalQ3Zzlsd3pSWmFjMjF6RTBWSUdHb3Fz?= =?utf-8?B?a2o2bXZHQ1ViVVJiTldBa0drUVBhT0x4RUlybjhqQ0YyYmRjSlNRV1hhRTVN?= =?utf-8?B?K2JqRTRoZ2dDS2hDUXQxYTJuOFpQNFlDa0h0Qlk1clJYYmgzclNmcVViVEZH?= =?utf-8?B?Q0VWcHhHNGJGaE85bmZXRDNJUlpyeTN0NzEzb0xmV1FhUWpVellVVFgyVkE3?= =?utf-8?B?eE5XM0FJKzEyS2c4S1NPRE5sQzVmRUl4K1puMnJRZVZwYkhHV0hSN25UQSt2?= =?utf-8?B?ekVCY2xPZlJHQ1NzTzkwZUpxTDhtaTlOZjRud09zVEZGRUVMUndNNzdCQUhw?= =?utf-8?B?aHBEd1hMaWZ3YStydjYvNjBBaks5UDFYb01YNG82Y1M0ekNiZ3gzd1ZlUytS?= =?utf-8?B?NUczUjhkc0JpT0w5OGQ3NU1XMkNTdnNKVHpLOHdGMUlsNmtwOWErd21UVy9U?= =?utf-8?B?YzdSZ3lJUktlYmNYLzB2YktMdllaZ0ZLd3hYNTVHK0UyQ0syeC9FdmNaMWht?= =?utf-8?B?aXRvZTVMM2UyUXdrVURySXlFVkdWRnAreXZtZkNEVXY5YjV1dlFsdmhqWlRq?= =?utf-8?B?c0I1WVY0SzNhVCtaWlJGamJRclMzay9PYWNHQTJ0NE0vVVZ4ckdKOFBrUnpv?= =?utf-8?B?RWYxREUvQis0NGZsNkhEbE9NT0V2dndaYnNON2JaNzVVaTgwUTRsMW9NSXJ4?= =?utf-8?B?MTlpTHJERkVaVHZadUhYTGRzNUpEYkliWkZOK3VkMy8xYVJ5WVVidERLaE44?= =?utf-8?B?WWlRTjF2a1l4NTdJZEdiR2wzZ1RSYzNxSWFtdHVKd0ZWWDhHam4xT2VhYXQr?= =?utf-8?B?dC9SbUxtZkJvQjd3RC9iTzBOQVhYMGJCQnVscjhaZ2JxUVlkaDZzRmgydXVX?= =?utf-8?B?bWdQUS9LelZ1RjFRdW5aalZzNjd1dUxkMmNwdGxlbTgzQjI0T2lwRWJMMHhR?= =?utf-8?B?SGRZelAvc005TkJqSytsVjdiREhkWXM1ZS9tVDd5TlhYZ0Q1WmVTTFJOa21P?= =?utf-8?B?WXJqVWZxdmNNdG9qL2lOTW45ZldEZjkwd0FUbjVXUi9jWWxSNGtXSUQ4N2ox?= =?utf-8?B?WmpwcHBYeVBPMW0zcjE0cW80WUlSVVhiUzEvaDZoR1hMaWlxZE1lbkFaMXcx?= =?utf-8?B?RlJ0ZEV3ZVp4NG84UEdUa0hoUnl0dVYxcG91TWlUME1qc0hvQ3VncXlRd2gz?= =?utf-8?B?WnFwSW54ODVCam5wYjBTMG1jYS92NXlQT3F1ejVodHRiRzVVd1M2RE9SWXRr?= =?utf-8?B?ZDdQZVA4c2pqVnlBYm5LTUJITmhvWGN2RndVdWZ2WGczUHl2M3JDL2ZtRDQ3?= =?utf-8?B?TWM4dDl0MmFvTG5KdmdsYVAvYkdaOHVXTnRpZUlrTW1RN21abHF3cDRqOStx?= =?utf-8?Q?OZXMiX5pF8e81uDI=3D?= X-Exchange-RoutingPolicyChecked: AVxRXzC5JWrBfs/YhYLQVIiEed6IxJkezCQVHoREAVllct0ZHAP73bZN0ame8bDn+M2yPjP32rr+r0P3VZvQrTeVy0/2PfDw18xoZoNAeObiHbYCSmhA18dxnB6hCImoloCy7YSflFOmS55MqdbfPOHoNKbE8+B8645BLsbIbAXurjvUsC6vMpov6IjtHjt5EZeMGja3HmujYMpm18lAee5x8B3SNgiCLTE6bVfSbJfTF6hxqPwcgdDAh4jSA/k1Cf1l1ueDHVs09BX1DXp83+fBPA+SQi6E7Hegp5PfCzOF+hfFUSoEGzABF10thzrG6XnAIEqBDOpuRt00ytafgg== X-MS-Exchange-CrossTenant-Network-Message-Id: d0b47638-b3c0-4c1d-4514-08de845bae6c X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8172.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2026 19:30:43.8812 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SrrSUAQv+MHeIZcAE+XNL50llzcG0RH/4Rtavjmf8KLbsFK7qSFjIna6wuSm5a4WTRr45Y5NNbwQokdrFN7hdMOQxIRbY+QfqeXu2GsE4Ck= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4649 X-OriginatorOrg: intel.com On 3/17/2026 7:38 AM, Sebastian Andrzej Siewior wrote: > On 2026-03-17 07:20:18 [-0700], Tantilov, Emil S wrote: >>> Why is there a raw_spinlock_t? From a quick look a spinlock_t would do >>> just fine with not runtime change for !PREEMPT_RT. >> >> The handling of the virtchannel messages is done via the completion API >> and the transactions are using the raw spinlock from struct >> swait_queue_head: >> >> https://elixir.bootlin.com/linux/v6.19.8/source/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c#L298 >> >> https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git/tree/include/linux/swait.h?h=dev-queue#n44 > > I am aware that completions use a raw_spinlock_t. I don't see the link. > What would break if you make that lock a spinlock_t? Right. Scope and risk - these fixes are specifically for the async handler and I did not want to touch the global locking that will impact the entire VC handling. We do have series in flight for -next that refactor that code, while moving it to libie: https://lore.kernel.org/netdev/20251117134912.18566-10-larysa.zaremba@intel.com/ ... that also remove the raw spinlock. With that being said, I can look into converting the lock to spinlock_t if that is the preferred approach. Thanks, Emil